Dots don't appear on tab/full staves
Ubuntu Studio 14.04, GIT commit: 47b4909
1) new score, electric guitar tab, 6-str full
2) note entry
3) enter dotted quarter note ("Shift+5 . 1")
Result: no dot appears
It seems the chord has dots == 1, and the layout code is dutifully trying to lay them out, but the dots themselves were never created (_dots[0] == 0).
Comments
Once upon a time, dots were 'built-in' into the Note object; then, the NoteDot object was introduced, but its creation was inserted in a point which, perhaps, makes sense in itself, but is in an execution flow which is entirely skipped for TAB's.
Looking for the better place to add it back...
M.
Yes, and it's possible that even worked at one time as ell. I believe the creation of dots was moved earlier at some point while I was working on layout improvements earlier this year, although I forget the exact details. I remember there was a point where I'd have wanted the dots but they weren't there yet, so I used some kludgy workaround. Something to do with the code for deciding whether to put dots above or below lines, maybe. Werner decided to rearchitected things a bit before merging my code, with the end result being that dots are now created somewhere different than they were, say, six months ago.
PR pushed to github
M.
Fixed in 9594716f69
Seems to work well for "common", but only very erratically for "full":
1) new score, acoustic guitar tablature, 6-str full
2) first measure, note entry
3) select dotted quarter as duration
4) "1 Right 1 Right 1 Right 1 Right 1 Right..."
Result: some of the dots show up, some don't. Obviously, some of these notes end up being tied over the barline and hence don't have ties - I'm not talking about those :-).
Seems erratic, like different results every time. But when I use debugger to show me the notes that should have dots but don't, I see the NoteDot element exists this time - now I guess it's the layout code that is failing.
I can no loner reproduce, but I swear this was happening the other day! I'm marking this "fixed" again but adding it to my "watch" list to verify again before release.
Automatically closed -- issue fixed for 2 weeks with no activity.