inconsistency dealing with note heads
while investigating why notehead names are not translated in a) edit drumset (fixed in 50313cc) and b) inspector I found the following inconsistencies:
the number and the order of noteheads in mscore/editdrumset.cpp#L38
is different from libmscore/note.cpp#L122
(alt.brevis missing and mi in a different place). Between that and libmscore/note.h#L55
, the order differs (the mi), but matches that of mscore/editdrumset.cpp#L38
, only that the latter is missing the last entry, "alt. brevis".
mscore/inspector/inspectorNote.cpp#L37
matches the order in libmscore/note.h#L55
.
As per editdrumset.cpp#L73 the last notedheads get skipped for drumsets, don't they apply here?
Shouldn't noteHeadNames[] get completed and moved from edditdrumset.cpp to note.cpp?
How to sort the inconsistency in order?
Comments
The order of noteheads in mscore/editdrumset.cpp#L38 has to match the order of NoteHead::Group so this can work. It could be modified to use data in the item though.
AltBrevis and sol don't make any sense in drums, that's why they are not listed.
The order of libmscore/note.h#L55 is inherited from 1.3 I believe. And it's different from mscore/inspector/inspectorNote.cpp#L37 because we want a more logical order in the UI.
oops, missed that sol was missing (and in a different order) too.
inconsistencies fixed by lasconic in 278a3d4
now I'll try to fix the Translation issue.
Fixed in 0c953d4535
Automatically closed -- issue fixed for 2 weeks with no activity.