Sparkle: Closing MuseScore terminates update on macOS

• Dec 23, 2019 - 21:17
Reported version
3.3
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
active
Regression
No
Workaround
No
Project

The Sparkle updater on macOS is in a separate dialog to MuseScore's main window. However, if the user closes MuseScore's window during an update then it also closes the Sparkle dialog, which terminates the update.

Possible solutions:

  1. Keep the Sparkle dialog open even if MuseScore is closed (i.e. the Sparkle dialog should not be a child of MuseScore's main window).

  2. Make the Sparkle dialog modal, so it is not possible to close (or interact with) MuseScore's main window during an update.

  3. Simply provide a warning not to close the main window during an update.

Note that the WinSparkle updater on Windows has the opposite behaviour. On Windows it is possible to close MuseScore without terminating a WinSparkle update, and in fact you are required to do so as the installation will not complete if MuseScore is running.


Comments

In reply to by Jojo-Schmitz

Indeed, with Windows one has to keep MS open until the update is downloaded. If MS is closed before it is completed the download is aborted. Then after starting the update one has to close MS or else the update doess not complete - a minor irritation, but an irritation nontheless. It is easier to update using a manual download than from the invitation to update that pops up when MS starts.

@Jojo-Schmitz, @SteveBlower, correct. I was wrong.

  • Closing MuseScore terminates the download on both platforms.
  • On macOS it also terminates the installation of the update.
  • On Windows, you are required to close MuseScore for the installation to complete.

The proposed solutions are still valid.