Melisma lines too long
Ubuntu 14.04, GIT commit: 83622b0
The new melisma implementation seems to be working great. Just one issue I've seen, also pointed out by Jojo-Schmitz: the lines are too long now. According to Gould, they should extend only to the right-hand edge of the last note they cover, not all the way to the next note. This worked as expected in the original implementation.
I will look into fixing this ASAP, unless Miwarre is around...
Comments
Fixed in 27695a68b5
Currently it takes into account ledger lines, which causes them to be a bit too long still when the note is off the staff. I noticed this as I was typesetting a choral score, and saw that the same word in multiple parts has varying melisma line lengths.
True, and I had noticed that too. Unfortunately the sizes of the ledger lines are already baked into the bboxes for the chord & notes. I guess we could check the notehead and look up its width in the font (and multiply by the mag factor for the note) rather than simply using the note width. Or at least, we could do that once my updated code that looks at the notes within the chord is merged. I'd be able to live with it as is, though.
Automatically closed -- issue fixed for 2 weeks with no activity.
In reply to #3 by Marc Sabatella
Marc, can you update us on this issue. I guess it was decided not to fix this? Admittedly, it is a small issue but it looks visually messy when the melisma lines extend to long.
You mean about the ledger lines? You'd need to open a new issue for that. But the original described in the initial post is fixed. or, if you some some particular case you are thinking you are seeing otherwise that is not due to ledger lines, please attach a sample score so we can investigate.
In reply to You mean about the ledger… by Marc Sabatella
Here is what I am talking about. The OP is entitled "Melisma lines too long" I did this with Version 3.5.
![Melisma Example.png]( "Melisma Example.png")
That's not what this issue about, it was about a normal/correct melisma extending somewhat too far, but not overlapping anything. Your example doesn't make sense to me - there is no melisma at all here, so it's not clear why you added a line. But, if you force a line to appear where not appropriate, you can indeed get odd results like this.
It seems you are probably misunderstanding something about how melisma lines are supposed to work, but it isn't obvious what. Best to ask for help in the Support forum and attach an actual score you are having trouble with so we can understand better what you are doing. but in normal circumstances and when used correctly, the melisma lines should already display correctly.