Crash deleting tempo text from score created from template with linked parts

• Feb 25, 2015 - 16:41
Type
Functional
Severity
S2 - Critical
Status
closed
Project

Ubuntu 14.04, GIT commit: e75affa

1) new score, flute+oboe
2) add tempo text to measure 1
3) generate parts
4) save to Templates folder
5) (restart musescore - may be needed for the new template to show in list)
6) new score, select template you just created
7) select tempo text
8) delete

Result: crash

Only seems to happen if the template already has parts generated. From what I see in debugger, it appears the tempo text has a bad (garbage) value for _parent. This happens for other system text types too, although perhaps not as reliably (?). The crash actually happens while processing the element in one of the linked parts.

To me, it's debatable whether we should be preserving the text from the template anyhow. We apparently do this only for measure 1, which I guess does make sense if we are to do it at all.


Comments

Werner just explained me the following:

The fix comes with a new implementation on how the templates are used to create new scores. It used to be that the template was used to create a score and by deleting notes, measures, etc... so modifying the template. The new implementation creates the score from scratch just using the instrument information of the templates.

Question:
* How it work for for page layout? we have some templates in A4. And we had some templates with no page layout to inherit from the user default. Can we make sure it work?

* Part should be ok.
* Linked staves too.
* What about style + text styles for jazz templates.

More test needed.