Remove "public domain" from license options in Save Online ...
On musescore.com, we retired the "Public Domain Mark" option under the licenses. The reason is that for newly work, the creative commons copyright waiver, i.e. CC0 should be used instead.
Simply scrapping public-domain as possible option is not the right solution though as there will be existing work on musescore.com under this license. So in case a score is edited (and saved online) which has this license option, the option should be listed and selected in the license options list. In case the work has not been saved online yet, or has another license selected, the public domain mark should not be listed.
While on this issue, also update the wording to be on par with the licensing terms on musescore.com.
Once applied to master, this issue can to be backported to 2.1.
Comments
Perhaps the software could pull it's list from the website somehow? It would ensure they remain in synch and future changes only need to happen on the server then.
@Jeetee We actually used to interface the musescore site with the creative commons api to pull in their licenses, but scrapped it as their api wasn't stable enough. Given our bad experience with that, we don't want to end up in the same situation. Anyhow, this list isn't going to change anymore any time soon.
Actually I was suggesting to have the musescore application interface with the musescore.com site to retrieve the list. How musescore.com manages/creates it wouldn't matter then.
Got it. It's just an extra moving part. For now, I decided not to do this.
Would adding `if (updateExistingCb->isChecked())` to mscore/uploadscoredialog.cpp, line 65 be sufficient?
Problem with master is that we can't really test it, as that "Save online" is disabled there.
And while being at that dialog: the link there to http://musescore.com/help/license doesn't work anymore. Most probably needs to get fixed on the server, as we can't fix it for the existing MuseScore 2.0.x anymore. Maybe just redirect to https://help.musescore.com/hc/en-us/articles/210386805-Choose-a-license
Thanks for reporting that link issue Jojo. I will be using this link instead now redirect.musescore.com/help/license which will redirect to the help section.
That redirect link you mention doesn't help with that hardcoded link inside musescore
Fixed in branch 2.1, commit 8bd7883585
fix #169296, fix #169161: update to upload dialog
Fixed in branch master, commit d3a86953a4
fix #169296, fix #169161: update to upload dialog
@Jojo the legacy url will be fixed.
@Jojo legacy url's are fixed:
* https://musescore.com/help
* https://musescore.com/help/license
Well, not quite, it gets me to https://help.musescore.com/hc/en-us/search?utf8=✓&query=license
But better than a 404 error ;-)
It's on purpose. https://musescore.com/help/% goes to https://help.musescore.com/hc/en-us/search?utf8=✓&query=%
Automatically closed -- issue fixed for 2 weeks with no activity.