Playback when adding an accidental

to7m

• Feb 9, 2018 - 19:01

Reported version

2.1

Type

Functional

Severity

S5 - Suggestion

Status

closed

Project

MuseScore

https://musescore.org/en/node/269268

This suggestion is to implement playback when adding an accidental to a single note via the accidentals toolbar or a keyboard shortcut, to be consistent with playback for other types of note.

Comments

mattmcclinch

• Feb 10, 2018 - 09:16

Status (old)	active	⇒	patch (code needs review)
Status	active	⇒
Type	Graphical (UI)	⇒	Functional

The other part of this feature request was to add a command (that can have a keyboard shortcut) to delete the accidental for a selected note (or notes) without having to select the accidental itself. This command, as well as the playback when adding accidentals, is implemented in this pull request. It is up to the user to specify the keyboard shortcut to use, but the command is "Note input: No accidental".

Git Message

• Feb 15, 2018 - 10:03

Status (old)	patch (code needs review)	⇒	fixed
Status		⇒	fixed

Fixed in branch master, commit d6bdc192fb

fix #269280: Playback when adding an accidental

Git Message

• Feb 15, 2018 - 10:03

Fixed in branch master, commit ad89d0c5ac

Merge pull request #3459 from mattmcclinch/269280-play-accidental

fix #269280: Playback when adding an accidental

Jojo-Schmitz

• Feb 15, 2018 - 13:10

Status (old)	fixed	⇒	patch (ready to commit)
Status	fixed	⇒	PR created
Reported version	3.0	⇒	2.1

That one-line patch should be good and harmless enough to make it into 2.2 too. It does git cherry-pick cleanly

Jojo-Schmitz

• Feb 15, 2018 - 14:17

Status (old)	patch (ready to commit)	⇒	active
Status	PR created	⇒	active

See https://github.com/musescore/MuseScore/pull/3459#issuecomment-365937082:
I just realized this doesn't work when adding accidentals from the palette. setPlayNote(true) should be moved to the end of void Score::changeAccidental(Note* note, AccidentalType accidental)

mattmcclinch

• Feb 15, 2018 - 17:56