Some translated Tours strings show up as untranslated

• Mar 7, 2019 - 09:50
Reported version
3.x-dev
Type
Wording/Translation
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

Related to :
- #280538: Some Tours strings show up as untranslated
- #285019: Tours strings for French shows up untranslated

Tested with :
- OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.5886, revision: dd5cfaf

Some examples:
- Welcome - Main menu
Tours_fr-Welcome-Main_Menu.png

  • Welcome - Score view
    Tours_fr-Welcome-Main_Menu.png

  • Note input - Rnter note
    Tours_fr-Note_Input-Enter_Note.png

  • Note input - Add accidental
    Tours_fr-Note_Input-Add_Accidental.png

And some others tours have to be checked.


Comments

Title Many French translated Tours strings show up as untranslated Many French translated Tours strings show up as untranslated in development builds
Frequency Once Few
Reported version 3.0 3.x-dev

Update :
- After the switching of ressource manager to Master 3.1.0, all new string has been pushed to Transifex.
- 8 Tours strings had to be retranslated - > Done for French.
- 47 total tours are translated.
- One still shows as untranslated = Welcome -> This is the score view.

Tours_fr-Welcome-Score_View.png

  • I have tried to switch MuseScore Language to German DE, Reinit tours, restart, the same string shows as untranslated.

OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6155, revision: 09ef1d4

Title Many French translated Tours strings show up as untranslated in development builds Some translated Tours strings show up as untranslated

OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6437, revision: 06f0ddd
OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6434, revision: 25c8a3e

The reason is because the file "tourxml.h" in "https://github.com/musescore/MuseScore/tree/master/share/tours" is outdated.
For example, in the Welcome Tour, the string "This is the score view, where you can view and edit your score.
Use your mouse wheel or touchpad to scroll (with "Shift" to scroll horizontally).
If you have multiple scores open, you can switch between them using tabs at the top of your score view." is different of those find in tourxml.h "This is the score view, where you can view and edit your score.\n Use your mouse wheel or touchpad to scroll (with Shift to scroll horizontally).\n"

You can see that the quotes around the word Shift does not exist.

As tourxml.h is outdated, the tours_*.ts are also outdated, and the source string in Transifex is also outdated.

The solution could be to regenerate tourxml.h and update .ts files and update Transifex.

Good point, thanks for that analysis!

And while at it the same method should be used to regenerate instrumentsxml.h

There's a python script doing this, I guess it should be possible to run that in the "MacOS_lupdate" job on Travis CI?

In reply to by Jojo-Schmitz

Thanks for this readme, it precise the steps to update strings.
Automate the update in Travis would be an help to not forget a new or updated string.

As I can see, there is "script.sh" in "https://github.com/musescore/MuseScore/tree/master/build/travis/job_mac…"

Where the translation update is in lines :
Translation routines
update translation on transifex
./build/gen-qt-projectfile . > mscore.pro
lupdate mscore.pro
./build/gen-instruments-projectfile ./share/instruments > instruments.pro
lupdate instruments.pro
./build/gen-tours-projectfile ./share/tours > tours.pro
lupdate tours.pro

A call to the python files could be here.

In the mean time of this modification, could we have the tours strings updated before 3.1.0 release ?

No, I tried and failed, but I got access to a Linux machine, transfered that tours directory there, ran the script and transfered tourxml.h back ;-)

Fix version
3.1.0