Previous/next element commands should not wrap around begin/end of score

• Sep 14, 2019 - 22:05
Reported version
3.2
Priority
P2 - Medium
Type
Functional
Frequency
Once
Severity
S5 - Suggestion
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
MuseScore
Tags
accessibility

After navigating to the beginning of a score (eg, by pressing Alt+Left repeatedly), navigation should stop and not wrap around to the end. Wrapping makes it too hard for a blind user to tell when they've reached the beginning. Conversely for Alt+Right at end of score wrapping back to the beginning.

Relates to #277496: [EPIC] Accessibility issues/suggestions

Comments

• Sep 30, 2019 - 22:17
Status PR created ⇒ fixed

Fixed in branch master, commit 2f2aa3c731

_fix #294485: don't wrap to begin/end on next/previous element

Blind users find it disorienting for the previous element command to wrap to the end,
or for next element to wrap back to the beginning.
Besides, no other navigation commands work that way.
This commit stops that behavior by simply swapping the calls
to Score::lastElement() and Score::firstElement() in the places where this wrapping occurs.
That is, if previous-element finds no previous element,
we return the first element._

Reply

Fix version
3.3.0