Volta/Ottava/Pedal lines disappear when switching language
Reported version
3.6
Type
Functional
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
active
Regression
No
Workaround
Yes
Project
OS: macOS High Sierra (10.13)
Arch.: x86_64, MuseScore version (64-bit): 3.6.2.548020600
revision: 3224f34
Step to reproduce:
1.Insert Volta or Ottava or Pedal line via Line Palette
2.Switch language to another. (it happens in any combination)
Result:
Line disappears. (img is Volta)
And Line style also disappear via format ->style
Workaround:
[I’m not 100% sure, sometime it doesn’t work..]
Clicking Reset to default button & relstart MuseScore
Attachment | Size |
---|---|
volta4.jpg | 67.34 KB |
volta1.jpg | 21.69 KB |
volta2.jpg | 28.94 KB |
vota3.jpg | 21.99 KB |
Comments
I can't reproduce. Is it happing on switich to a certain language, or on any?
I've seen scores being broken in that way, in the forum see https://musescore.org/en/node/317546 and https://musescore.org/en/node/319014
might be a duplicate of #319020: Brackets for Voltas disappeared
In reply to might be a duplicate of … by Jojo-Schmitz
Hi Jojo, try opening attached score, and
1.put volta
2.switch language.
*seems processing (already writing a lot) / completed score are working fine.
I don't know why..
It crashes when I try it on that score
Only on the 1st attempt, can't reproduce the crash, mit relate so something I did in the session before that
I still can't reproduce the vanishing volta line
In reply to It crashes when I try it on… by Jojo-Schmitz
ohh... now it works fine for me too.. confusing..!
I'll post if I will find the way to reproduce this.
In reply to ohh... now it works fine for… by kazuma yamamoto
jojo, maybe maybe.. try this.
Open attached score,
1.go to style via format -> style
2.click any item of the left, e.g. Score
3.click OK
4.switch language
Result:
first measure volta line disappears.
OK, with that I can reproduce it
Format > Style > Volta > Line style is empty then
As are all other line styles (ottava and pedal).
Suspicion: those get stored in the score or in memory using their translated names?
In reply to OK, with that I can… by Jojo-Schmitz
Ok! Good thanks
I might have found the culprit...
Compare the code from the constructor (
EditStyle::EditStyle(Score s, QWidget parent)
):with that from where the retranslation happens (
void EditStyle::retranslate()
):Looks like a classic off-by-one error to me (and a duplicate line too)
Problem is: in my current (debug) build I can't reproduce the issue, so can't check whether the fix works
See https://github.com/musescore/MuseScore/pull/7804
Maybe you could try whther https://github.com/musescore/MuseScore/suites/2352883332/artifacts/4976… (for macOS, GitHub account needed) fixes it for you (as opposed to the latest development build, https://ftp.osuosl.org/pub/musescore-nightlies/macos/3x/nightly/MuseSco…)
As far as I can tell this bug does not exist in master, which will become MuseScore 4.
In reply to Maybe you could try whther… by Jojo-Schmitz
Thanks!
Seems the bug is still exist in both links which you provided me above (I have GitHub account)
Anyway, it's good that the bug will be solved in MU4 :)
Well, if my code change for MuseScore 3 doesn't fix it, I'm not sure the same issue won't happen in MuseScore 4.
How did you reproduce the issue with the GitHub artifact?
In reply to Well, if my code change for… by Jojo-Schmitz
I just did the same reproducing way for GitHub artifact,
1.go to style via format -> style
2.click any item of the left, e.g. Score
3.click OK
4.switch language
OK, with the GitHub artifact I can reproduce it too (still)
Not with my self built one though :-(
In reply to OK, with the GitHub artifact… by Jojo-Schmitz
OK,
Thank you for working on this :D
In reply to OK, with the GitHub artifact… by Jojo-Schmitz
What I've found;
No need to click OK, but just close the style window cause the bug.
There a re a few diffences between my self built version vs. GitHub artifact:
From these the last one seems the most likely candidate
Fixed in branch 3.x, commit 072a0a19e3
_Fix #319242, fix #319020: Volta/Ottava/Pedal lines disappear when switching language
and while at it also remove a duplicate line and an unused variable_
PR has been merged, but as mentioned this doesn't really fix the issue
In reply to PR has been merged, but as… by Jojo-Schmitz
OK, thanks jojo :D
I’m not familiar with Qt,
But I assume that
The bug will be (hopefully) solved if next releasing (MU4) will use updated version of Qt.
That version, as far as I can tell, doesn't have the bug in the first place, but yes, it will be using a newer Qt version (5.15)
In reply to That version, as far as I… by Jojo-Schmitz
OK, hope it will be fixed!