Volta/Ottava/Pedal lines disappear when switching language

I can't reproduce. Is it happing on switich to a certain language, or on any?

I've seen scores being broken in that way, in the forum see https://musescore.org/en/node/317546 and https://musescore.org/en/node/319014

might be a duplicate of #319020: Brackets for Voltas disappeared

It crashes when I try it on that score

Only on the 1st attempt, can't reproduce the crash, mit relate so something I did in the session before that

I still can't reproduce the vanishing volta line

OK, with that I can reproduce it

Format > Style > Volta > Line style is empty then
As are all other line styles (ottava and pedal).

Suspicion: those get stored in the score or in memory using their translated names?

I might have found the culprit...

Compare the code from the constructor (EditStyle::EditStyle(Score s, QWidget parent)):

      int dta = 1;
      voltaLineStyle->clear();
      ottavaLineStyle->clear();
      pedalLineStyle->clear();
      for (const char* p : lineStyles) {
            QString trs = qApp->translate("EditStyleBase", p);
            voltaLineStyle->addItem(trs, dta);
            ottavaLineStyle->addItem(trs, dta);
            pedalLineStyle->addItem(trs, dta);
            ++dta;
            }

with that from where the retranslation happens (void EditStyle::retranslate()):

      int index = 0;
      for (const char* p : lineStyles) {
            QString trs = qApp->translate("EditStyleBase", p);
            voltaLineStyle->setItemText(index, trs);
            voltaLineStyle->setItemText(index, trs);
            ottavaLineStyle->setItemText(index, trs);
            pedalLineStyle->setItemText(index, trs);
            ++index;
            }

Looks like a classic off-by-one error to me (and a duplicate line too)

Problem is: in my current (debug) build I can't reproduce the issue, so can't check whether the fix works

See https://github.com/musescore/MuseScore/pull/7804

Maybe you could try whther https://github.com/musescore/MuseScore/suites/2352883332/artifacts/4976… (for macOS, GitHub account needed) fixes it for you (as opposed to the latest development build, https://ftp.osuosl.org/pub/musescore-nightlies/macos/3x/nightly/MuseSco…)

As far as I can tell this bug does not exist in master, which will become MuseScore 4.

Well, if my code change for MuseScore 3 doesn't fix it, I'm not sure the same issue won't happen in MuseScore 4.

How did you reproduce the issue with the GitHub artifact?

OK, with the GitHub artifact I can reproduce it too (still)

Not with my self built one though :-(

There a re a few diffences between my self built version vs. GitHub artifact:

• MinGW vs. MSVC
• Debug vs. RelWithDebInfo
• Qt 5.15.2 vs. Qt 5.9.8

From these the last one seems the most likely candidate

Fixed in branch 3.x, commit 072a0a19e3

_Fix #319242, fix #319020: Volta/Ottava/Pedal lines disappear when switching language

and while at it also remove a duplicate line and an unused variable_

PR has been merged, but as mentioned this doesn't really fix the issue

That version, as far as I can tell, doesn't have the bug in the first place, but yes, it will be using a newer Qt version (5.15)