Privacy Policy link is not working after Reset to factory defaults.

• Dec 31, 2021 - 18:06
Reported version
3.6
Type
Functional
Frequency
Few
Severity
S4 - Minor
Reproducibility
Always
Status
won't fix
Regression
No
Workaround
Yes
Project

1.- Reset to factory defaults
2.- Run program (Debian, MuseScore v: 3.6.2.5480 AppImage) Privacy Policy link is not working after Reset to factory defaults in the first dialog regarding sending anonymous reports.

Attachment Size
Screenshot from 2021-12-31 12-05-45.png 842.9 KB

Comments

Frequency Once Few

Instead of a full factory reset you could test this also by deleting the "starup\telemetry_access_requested" and "telemetry\allowed" entries of the MuseScore3.ini file.

Doing that I can confirm the issue, MuseScore 3.6.2, 64bit, Windows 10.

Looking at the code:

                TextLabel {
                    anchors {
                        horizontalCenter: parent.horizontalCenter
                    }
 
                    text: qsTr("For more information, please take a look at our %1Privacy Policy%2").arg("<a href=\"https://musescore.com/legal/privacy\">").arg("</a>")
 
                    onLinkActivated: {
                        permissionModel.openLink(link)
                    }
                }

seems to reveal that while the message is using the correct URL, the method to open that links uses an unset/empty variable link, so this probably never worked.

Nah, that's not it, it seems. Clicking that link results in:

Warning: qrc:/qml/TextLabel.qml:56: Error: Insufficient arguments (qrc:/qml/TextLabel.qml:56, )

Simple fix:

diff --git a/telemetry/qml/TextLabel.qml b/telemetry/qml/TextLabel.qml
index 9a484584bf..2172a017b5 100644
--- a/telemetry/qml/TextLabel.qml
+++ b/telemetry/qml/TextLabel.qml
@@ -53,7 +53,7 @@ FocusableItem {
         color: "#373737"
 
         onLinkActivated: {
-            root.linkActivated()
+            root.linkActivated(link)
         }
     }
 }