Edit arpeggios and spacers causes a crash

• Aug 6, 2017 - 21:08
Reported version
3.0
Type
Functional
Severity
S2 - Critical
Status
closed
Project
MuseScore
Tags
3.0alpha

335777d / Windows7

1) SATB template, or "Untitled" score (and add a bracket or brace)
2) Double-click for edit the bracket
3) Drag a handle for extend, or hit arrow up/down

Result: crash

- Same behaviour with arpeggios

Lines seems work (and ties-slurs too)

Comments

• Aug 7, 2017 - 10:08
Title Edit arpeggios and brackets causes a crash ⇒ Edit arpeggios, brackets and frames causes a crash

Frames edition is impacted too.

Reply

• Aug 18, 2017 - 08:25
Title Edit arpeggios, brackets and frames causes a crash ⇒ Edit arpeggios, brackets, spacers and stems causes a crash

Spacers and stems too.
Frames edit is solved since this nightly: 7365542 (rather between 180ad68 and 7365542)

Reply

• Aug 18, 2017 - 18:50

In my Nightly Build 180ad68 adding a Slur crashes MS....
The slur is added (drawed), but when you want to select the slur, or doing something else, MS is crashing...

Theo

Reply

• Aug 18, 2017 - 19:08

First, be sure you are using the very lastest  nightly. In this matter, the “truth” of a day is really not always that of the day after :)

The nightly you mentioned goes back to three days: 180ad68

I checked with this nightly. I cannot reproduce (with this nightly still).
It is needed to be precise in the steps you doing. Entering slurs how ? By drag and drop from the Lines palette, double-click (or "S" shortcut), and what you are doing exactly after that ? Double-click for edit mode, or something else?

Reply

• Oct 19, 2017 - 15:52
Title Edit arpeggios, brackets, spacers and stems causes a crash ⇒ Edit arpeggios, brackets, spacers causes a crash

With 6c735b8, I cannot reproduce this issue with Stems and Image Capture.
Always active for Arpeggios, Brackets and Spacers.

Reply

• Jan 23, 2018 - 09:26

For completing (3f57552/Windows7):
1) Arpeggios: at first glance, seems fixed. But I get always some sporadic crashes ("Untitled score", Page view), but I don't found yet why its works "almost" always. Below, a crash after adding a second arpeggio (usually, it works!)
arpeggio.jpg
2) Spacers: better too. But I get always some crashes when attempting to edit (SATB template) eg a spacer up after doing that for the spacer down. If its continues to work with two spacers, I achieve to receive crash by adding and editing other spacers.
opposite.jpg

Reply

• Jan 29, 2018 - 12:24
Title Edit arpeggios, brackets, spacers causes a crash ⇒ Edit arpeggios and spacers causes a crash
Status (old) fixed ⇒ active
Status fixed ⇒ active

50ddb57 / Windows10

I cannot reproduce the issue with the brace in Jazz Big Band template. Observe nevertheless you cannot, as expected, edit the brackets/handles with the Up/Down arrows. Only with the mouse.

Otherwise, I can always reproduce with the spacers. Eg: SATB template -> add and edit a spacer down -> without leaving edition (don't Escape, so, the handle is always highlighted) -> drag and drop a spacer up (image below) -> Double-click for edit this spacer up -> Result: crash
tenor.jpg
And it remains too a problem somewhere with arpeggios. I get always some sporadic crashes (two after about twenty various tests by editing arpeggios of two chords). But no coherence to receive these crashes.

Reply

• Feb 12, 2018 - 10:36
Status (old) patch (code needs review) ⇒ fixed
Status ⇒ fixed

Fixed in branch master, commit f1c36a6ed9

fix #240831, fix #267689: crash on editing arpeggios, spacers, brackets and stems

Added required call to the super startEdit() method to initialize ElementEditData for further usage in startEditDrag.
Removed nullptr check since it is actually useful to have crashes on master to find incorrect program states, but not just avoid occasional crashes.

Reply