Adding Intervals (above/below) should take into consideration the accidental toggle state

• Dec 4, 2019 - 21:28
Reported version
3.3
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

This has been mentioned a few times, but not added to the issue tracker, so for good measure:

1) Insert note, e.g. a C
2) Desire to add an E#, but do this via the interval commands rather than tonal commands.

Before version 3.3., the user could [Add 3rd above] and then use the [Accidental] commands like add #/double flat/whatever afterwards. Now, the accidental commands toggle, and the expected behavior is to have an interval be given the toggled accidental state, though no such thing occurs. And then the user can't add an accidental explicitly except by using the Semitone raising/lowering functions (arrows), or worse, exit note entry and then apply an accidental command. This interrupts work-flow for when someone uses explicit accidental commands rather than changing pitches up or down by semi-tones, and needs to be fixed.

So, basically, the bug can be declared as (and should hopefully be an easy fix):

[Add Interval] commands currently do not apply a toggled accidental state.

This potentially could be considered a major bug rather than minor...


Comments

Status PR created fixed

Fixed in branch master, commit 573280f1ca

_fix #298121: Adding Intervals (above/below) should take into consideration the accidental toggle state

Resolves: https://musescore.org/en/node/298121.

In addition to making the "Add Interval" commands apply the highlighted accidental when in note input mode, I have corrected a few cases where I had chosen the wrong tpc to use to calculate the AccidentalType for a user accidental, given the current value of styleB(Sid::concertPitch)._

Fix version
3.4.0