"Reset to Default" buttons in Inspector don't work on any frame text and works badly on repeat texts, fingerings, Swing and syst

• Apr 9, 2016 - 14:51
Type
Functional
Severity
S4 - Minor
Status
closed
Regression
No
Workaround
No
Project

The "Reset to Default" button in Inspector for text works fine for every text except the texts in a vertical, horizontal or text frame, namely: title, subtitle, lyricist, composer, partname and frametext.
On top the 'Reset to Defaults" button is always enabled, which indicates that curently the default for the selected text is not in effect currently, even if it is.


Comments

I think this is because these elements are all actually of the actually of type "Text", and there is no single default style for Text. The is, StaffText, RehearsalMark, etc are all distinct C++ classes so each has its own default text style type, but the elements you mention are all actually just generic "Text" type, so there is no way to query the element to find out its default.

Probably we could either define subclasses for each of these for that sole purpose, or else add a field to the Text class to record the "original" text style type, and use that to restore for generic Text. That is, change Text::propertyDefault() to not "give up" in the generic case, but instead return the value of that new field, which would be set when the text is created.

Title "Reset to Default" buttons in Inspector don't work on any frame text "Reset to Default" buttons in Inspector don't work on any frame text and works badly on repeat texts

Similar issue for repeat texts, although here it is even worse, the 'Reset to Default' works, but changes them to something entirely different, like changing the Segnos and Codas from "Repeat Text Left " to "Repeat Text" (which is especially bad), while it changes all the others (D.S., To Coda, etc) from "Repeat Text Right" to "Repeat Text" (only in this case there doesn't seem to be a visible difference), a style that exists for backward compatibility only.

It furtermore resets String Numbers, RH Fingerging and LH Fingering to Fingering
Swing text from Tempo to Staff Text, also System Text to Staff Text.

Title "Reset to Default" buttons in Inspector don't work on any frame text and works badly on repeat texts "Reset to Default" buttons in Inspector don't work on any frame text and works badly on repeat texts, fingerings, Swing and syst