Trying to open fingering palette crashes musescore nightly MLutz • Jan 22, 2017 - 23:21 Reported version 3.0 Type Functional Severity S2 - Critical Status closed Project MuseScore The newest nightly crashes, when I try to open the fingering palette (also in the master palette). afe8c2f Reply Comments Jojo-Schmitz • Jan 23, 2017 - 08:52 Confirmed with Windows 7 and a self-built afe8c2f. Stack trace: 1 Ms::Element::parent element.h 200 0xdda288 2 Ms::Note::chord note.h 411 0xdd688b 3 Ms::Fingering::layout fingering.cpp 69 0x88bbc3 4 Ms::Palette::paintEvent palette.cpp 914 0x4b354c 5 ZN7QWidget5eventEP6QEvent 0x1d54de01 6 ?? 0x28beec 7 ?? 0x2405d548 Reply Jojo-Schmitz • Jan 23, 2017 - 09:09 Easy (but not neccessarily correct) fix is in libmscore/fingering.cpp, line 68 to replace if (autoplace()) { with if (autoplace() && note()) { Reply Jojo-Schmitz • Jan 23, 2017 - 09:18 Status (old) active ⇒ patch (code needs review) Let's see whether https://github.com/musescore/MuseScore/pull/2969 passes muster... Reply Git Message • Jan 23, 2017 - 09:57 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit ce331dc5f7 fix #165196: crash on attempt to open fingering palette Reply Git Message • Jan 23, 2017 - 09:57 Fixed in branch master, commit 22743535f7 Merge pull request #2969 from Jojo-Schmitz/fingering-crash fix #165196: crash on attempt to open fingering palette Reply System Message • Feb 6, 2017 - 10:00 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • Jan 23, 2017 - 08:52 Confirmed with Windows 7 and a self-built afe8c2f. Stack trace: 1 Ms::Element::parent element.h 200 0xdda288 2 Ms::Note::chord note.h 411 0xdd688b 3 Ms::Fingering::layout fingering.cpp 69 0x88bbc3 4 Ms::Palette::paintEvent palette.cpp 914 0x4b354c 5 ZN7QWidget5eventEP6QEvent 0x1d54de01 6 ?? 0x28beec 7 ?? 0x2405d548 Reply
Jojo-Schmitz • Jan 23, 2017 - 09:09 Easy (but not neccessarily correct) fix is in libmscore/fingering.cpp, line 68 to replace if (autoplace()) { with if (autoplace() && note()) { Reply
Jojo-Schmitz • Jan 23, 2017 - 09:18 Status (old) active ⇒ patch (code needs review) Let's see whether https://github.com/musescore/MuseScore/pull/2969 passes muster... Reply
Git Message • Jan 23, 2017 - 09:57 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit ce331dc5f7 fix #165196: crash on attempt to open fingering palette Reply
Git Message • Jan 23, 2017 - 09:57 Fixed in branch master, commit 22743535f7 Merge pull request #2969 from Jojo-Schmitz/fingering-crash fix #165196: crash on attempt to open fingering palette Reply
System Message • Feb 6, 2017 - 10:00 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
Confirmed with Windows 7 and a self-built afe8c2f.
Stack trace:
1 Ms::Element::parent element.h 200 0xdda288
2 Ms::Note::chord note.h 411 0xdd688b
3 Ms::Fingering::layout fingering.cpp 69 0x88bbc3
4 Ms::Palette::paintEvent palette.cpp 914 0x4b354c
5 ZN7QWidget5eventEP6QEvent 0x1d54de01
6 ?? 0x28beec
7 ?? 0x2405d548
Easy (but not neccessarily correct) fix is in libmscore/fingering.cpp, line 68 to replace
if (autoplace()) {
with
if (autoplace() && note()) {
Let's see whether https://github.com/musescore/MuseScore/pull/2969 passes muster...
Fixed in branch master, commit ce331dc5f7
fix #165196: crash on attempt to open fingering palette
Fixed in branch master, commit 22743535f7
Merge pull request #2969 from Jojo-Schmitz/fingering-crash
fix #165196: crash on attempt to open fingering palette
Automatically closed -- issue fixed for 2 weeks with no activity.