[Guitar Pro] Copyright text not imported

• Oct 7, 2013 - 19:11
Type
Functional
Severity
3
Status
closed
Project
MuseScore
Tags
guitarpro

1. Open attached file (produced in TuxGuitar 1.2).

Result: Copyright text is not imported.

Using MuseScore 2.0 Nightly Build (0bc17a9) - Mac 10.7.5.

Attachment Size
Copyright text not imported.gp5 1.46 KB

Comments

• Aug 6, 2014 - 11:58
Severity ⇒
Status (old) closed ⇒ active

Hi jpirie

Thanks for the Guitar Pro fixes.

I want to re-open this because the text isn't the same.

Expected result (from TuxGuitar 1.2): 'A test to see if copyright text is imported'

Actual result: 'Copyright A test to see if copyright text is imported
All Rights Reserved - International Copyright Secured'

Using MuseScore 2.0 Nightly Build (601b10b) - Mac 10.7.5.

Reply

• Aug 6, 2014 - 12:33

We have this line in the copyright import part of the Guitar Pro codebase:

score->setMetaTag("copyright", QString("Copyright %1\nAll Rights Reserved - International Copyright Secured").arg(copyright));

That text is always bolted on to the copyright statement. I left this string untouched and just applied the same for all versions as I assume the initial author had some motivation for putting that there. I'm happy to remove the additional text though unless there are any objections...

Reply

• Aug 6, 2014 - 14:07

Seems inappropriate to me to modify the copyright message, unless perhaps that what Guitar Pro does. That is, I think we should import the copyright verbatim.

Reply

• Aug 6, 2014 - 17:13

I agree, this change will be present in my next PR, which I should be making later today. If anyone has further issues just let me know.

Reply