On Nightly 6166df5, inserting any notes into a score results in a crash.
To Reproduce:
Create or open a score.
Insert a note.
Expected: The note is placed.
Actual: It's heard, but the application freezes.
Can you reduce the problem into starting to happen between 6166df5 and d10ae91? For either there are nightly build for Windows available and they are just one commit apart.
Edit: for me d7c7838 already has the problem, the previous one, b8c3324, does not.
The possible source for the problem could be the reintroduction of the HEAD_BREVIS_ALT note-head group, since now the heads array in mscore/inspector/inspectorNote.cpp is too short and the program can access garbage memory (overflow). Decommenting line 51 of mscore/inspector/inspectorNote.cpp could solve the problem. https://github.com/musescore/MuseScore/blob/master/mscore/inspector/ins…
Comments
What OS? How are you inserting the note? Are you sure it's "any" score? I don't see this using a build from latest sources.
I am on Windows 7, and I have inserted the note onto a blank score by using the mouse.
I can confirm this nightly crashes immediately on note entry. I suspect it may be a bad build.
Maybe same as my issue. Musescore crash also when selecting random note in a loaded score.
Can you reduce the problem into starting to happen between 6166df5 and d10ae91? For either there are nightly build for Windows available and they are just one commit apart.
Edit: for me d7c7838 already has the problem, the previous one, b8c3324, does not.
The possible source for the problem could be the reintroduction of the HEAD_BREVIS_ALT note-head group, since now the
headsarray in mscore/inspector/inspectorNote.cpp is too short and the program can access garbage memory (overflow). Decommenting line 51 of mscore/inspector/inspectorNote.cpp could solve the problem.https://github.com/musescore/MuseScore/blob/master/mscore/inspector/ins…
Yep, that was my immediate thought too...
Actually the addition of HEAD_BREVIS_ALT in https://github.com/musescore/MuseScore/blob/master/libmscore/note.h#L105, which increases the value of NOTE_HEAD_GROUP. Doesn't mix and match with the loop in https://github.com/musescore/MuseScore/blob/master/mscore/inspector/ins…
PR https://github.com/musescore/MuseScore/pull/554 (with the fix 'stolen' from ABL, see above
Fixed in 11c4fb5f04
Automatically closed -- issue fixed for 2 weeks with no activity.