Crash opening score if text line is anchored to a multi-measure rest
STEPS:
- score with some rests
- create a text line that spans them
- Style -> General -> create multi-measure rests
- Save
- Close
- Open
RESULTS:
Crash due to unprotected access to sys in SLine::linePos
This can be avoided by checking for NULL sys in this function (I'll try to submit this fix).
There is a follow-on bug which is that the text line will not display if one of its ends is in a multi-measure rest, but you can only get there if this crash is fixed.
Comments
Proposed fix here:
https://github.com/musescore/MuseScore/pull/676
Reproduced.
Using MuseScore 2.0 Nightly Build (ea1e881) - Mac 10.7.5.
Sorry, my post had undone your changes.
Could you re-assign?
Thanks!
I'm not sure what the settings should be when submitting a patch, sorry.
How do you want me to assign it?
Thanks,
Z
I mean in this issue: Above the posting box, there's is a drop-down box that is currently 'Unassigned'.
Do you see it?
Probably a minor nit: it doesn't seem to follow the formatting rules, http://musescore.org/fr/developers-handbook/musescore-coding-rules
Fixed in d2c188e156
Thanks. I'll take a look at the formatting rules and setup my editor to match.
This was my first commit...
If you'ore using QtCreator, there is a configu file you can download right there on the coding rules page. It covers a good chunk of it. I think I get continuation lines wrong, but most other things work well if you remember where to put the opening brace (at end of statement and to start class def, line by itself for function)
Automatically closed -- issue fixed for 2 weeks with no activity.
Regression in 2b832e840
This bug is again reproducible with the original steps; OS Windows 8.1, 2b832e840 (self-built).
It was fixed again in 3ae79f8b
Automatically closed -- issue fixed for 2 weeks with no activity.