Crash by dragging a note from the drum palette when the top staff is a Tab, common or full

• Oct 26, 2017 - 11:51
Reported version
2.1
Type
Functional
Severity
S2 - Critical
Status
won't fix
Project

2.1 version / Windows10

1) Load this test file: drums tab.mscz (or a variant, without notes: variant.mscz )

2) Select first measure drumset staff/snare drum

3) "N"

4) From the drum palette, drag a note onto the score

Result: crash


Comments

Title Crash by dragging a note for drum palette when the top staff is a Tab, common or full Crash by dragging a note from the drum palette when the top staff is a Tab, common or full

This issue occurs on May 10, 2015.

  • This nightly works (ie nothing happens when dragging a note from the drum palette onto the score): 6356462
  • Crash with the next one: 506e5e8

So, the most likely it's a side effect of: https://github.com/musescore/MuseScore/commit/f44a3134953a051b13a2821b4…

To fix: #59881: Check "stemless" in Measure Properties works badly in Tab staff
and #59861: Tick "stemless" in measure properties for an irregular triplet and dotted notes causes a crash in Tab staff

Only an issue when dragging? I wasn't even aware that worked or was supported. I don't know that it really would work in general, probably other bugs exist if you try dragging. maybe best to simple disable it.

" I wasn't even aware that worked or was supported."

I wrote in this comment https://musescore.org/en/node/261992#comment-806216 that "this nightly works (ie nothing happens when dragging a note from the drum palette onto the score)"

By writing "nothing happens" doesn't significate that is was an issue in my mind!

I think too that is was not supported, but one observe the fix has introduce that in a certain way (or at least, or more exactly, this action leads to a crash in this specific case - necessary to have top tab staff "with stems", and drum palette.)

Yes, I have no trouble believing see that in some cases at least, drag & drop might work. The code for "drop" is used for various other actions as well, so for the cases where double click simply relies on the "drop" code exclusively, we're set. But there might be other cases where double click doesn't just rely on the "drop" code but does it's own processing that won't be performed on an actual drag & drop operation. Lots of things could possibly fall through the cracks. Not saying it couldn't be looked at, but I definitely wouldn't assume that simply fixing this crash - which appears trivial based on the the investigation thus far (thanks as always!) - would mean it's safe to use. Could lead to corruptions, places where the wrong note gets used or a note is palced on the wrong line, places where things change if you hit the Concert Pitch button, all sorts of things that might do wrong if the code wasn't specifically designed to handle drag & drop.

In reply to by Marc Sabatella

And after a further quick investigation, it worked also earlier (2014)! So, I guess that always worked! :)
We just had to think to drop the note specifically on a rest, or a note for edit (which I did not do before, I tried to drop on the entire measure!)

Status (old) active won't fix
Status active won't fix

Doesn't seem to occur in 3.0-dev, at least because I can not drop the note to the measure itself but only to another note. No crashes were spotted during that.
Since no updates on 2.X are planned, I'll mark it "won't fix" for now.

Tested on:
OS: Debian GNU/Linux 9 (stretch), Arch.: x86_64, MuseScore version (64-bit): 3.0.0, revision: b3feb3a