Crash on startup if user templates folder contains empty subfolders
- Do factory reset on MuseScore (it should subsequently open).
- 'MuseScore'>'Preferences'>'General'.
- Change Templates location folder to Desktop.
- 'OK'.
- Quit MuseScore.
- Open MuseScore.
Result: Crash (see attached log).
Note: It is also reproducible (in beta and nightly) if you change the location in 2.2.1.
Using MuseScore 2.3 Beta and 2.3 Nightly Build 8718b62 - Mac 10.11.6.
Attachment | Size |
---|---|
Crash after changing Templates location [Log].txt | 58.89 KB |
Comments
I couldn't reproduce this in 2.2.1 nor 3.0 Nightly Build 0196b1b.
I can't confirm, but I wonder if somehow this might not just affect templates, because I had another crash and I don't know if I changed its location.
It was the same log though, I think.
Neither for me. Windows, last self-built nightly.
I wonder if it's related to the actual contents of your desktop? Is this totally reproducible for you using that folder? What if you choose a different one - and empty one, perhaps?
Maybe MuseScore bans some content :)
Marc, I tried a new, empty folder called test, and I couldn't reproduce.
EDIT: After some more testing, I think it's because MuseScore doesn't like if there's a subfolder.
Thanks for the continued investigation. That was the clue I needed. Indeed, I got it crash just by adding an empty subfolder called "subfolder" to my empty Templates folder. The crash happens at the start of ScoreBrowser::setScores(), on the first line "qDeleteAll(scoreLists)". scoreLists appears to have trashed, not sure how. I'll let someone else investigate from here...
Are earlier versions affected?
It's only 2.3.
The problem is here : https://github.com/musescore/MuseScore/blob/a8158069b4b50e943fbd1f69503…
We delete the label and the scorelist but we don't remove them from the layout... This was already present, but now we clear the layout on update, and we try to clean these deleted widgets. PR to follow...
See https://github.com/musescore/MuseScore/pull/3755
Fixed in branch 2.3, commit 2ce6a55ae1
fix #273610: Crash on startup if user templates folder contains empty subfolders
Fixed in branch 2.3, commit a78c45eb25
Merge pull request #3755 from lasconic/fix-273610
fix #273610: Crash on startup if user templates folder contains empty subfolders
Automatically closed -- issue fixed for 2 weeks with no activity.