QDir::separator() vs. "/"
The current code uses
QDir::separator() in a few places, but
"/" in a lot other places.
While the former might be the correct way for being platform independant, the latter should work too, and in some cases even better.
We should go one or the other way, this wild mixture should not stay. And either way, it should get documented in the developers' handbook's coding style and in mscore3.txt.
My (current ;-)) opinion: go for
"/", it is the leaner change and as per the above links better and guaranteed to work on all platforms.
QDir::separator() is used twice in
ResourceManager::downloadLanguage(), and (now) in
ResourceManager::downloadExtension() and 3 times in thirdparty/gzip/qzip.cpp,
Maybe we don't want to touch thirdparty/gzip/qzip.cpp and/or get that fixed upstream, but
ResourceManager::downloadLanguage() uses MQZipReader (at least
MQZipReader::FileInfo()), not sure that matters.