Crash involving hairpins when deleting a staff

• Sep 25, 2018 - 14:39
Reported version
3.0
Type
Functional
Severity
S2 - Critical
Status
closed
Project

MuseScore 29204d56a4

> Crash


Comments

Title Crash when deleting a staff Crash involving hairpins when deleting a staff

Original score: Excellence.mscz

Always a crash by deleting the 2th staff, with the reduced file: 1minimal trumpet.mscz

By deleting the hairpin last measure (original measure 14), the crash is fixed: 1'minimal trumpet.mscz

But, if adding a new hairpin same measure, no more crash. Something went wrong before (score created there is three years?) Right now, I can't reproduce from scratch.

Status (old) active patch (code needs review)
Status active  

The pull request on this issue: https://github.com/musescore/MuseScore/pull/4018
The problem in reproducing this issue is that in the given scores there are empty staves which are hidden by the scores' style settings. These empty staves contained hairpins, and when trying to remove those empty staves the hairpins were not correctly removed in all exceprts, as explained in the pull request's description.

Status (old) patch (code needs review) fixed
Status fixed

Fixed in branch master, commit 288e0c349e

fix #276578: remove spanners for each staff when removing staves

Add a test to ensure that after removing a staff all elements belonging to it are also removed