Updating translations fails for some languages (but works for others)
Reported version
3.0
Priority
P1 - High
Type
Functional
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
Yes
Project
Came up in https://musescore.org/en/node/279961
The update attempts are shown as "Failed, Try again"
Works e.g. for German, fails e.g. for Afrikaans, there it downloads the locale_af.zip but doesn't unpack (and subsequently remove) it. Extracting them manually though works, so the archive doesn't seem to be corrupt.
Comments
Works ok for me, so... Needs info :)
Do all languages work for you? Tried Afrikaans, French?
Maybe Windows only?
as per https://musescore.org/en/node/279961#comment-878090 possibly related to some recent Microsoft updates or hotfixes?
Yes, tried French, Afrikaans, Russian, German
Tried on Windows (7 here and there), with latest Microsoft patches?
I don't see this on Windows 10
In reply to Tried on Windows (7 here and… by Jojo-Schmitz
Fortunately, I don't have Windows 7 :) Win 10 updates everything without problems.
Now it just gets stuck in updating, and when trying to update too many it crashes
I tried to upgrade to 10, but so far always lost sound, so had to fall back to 7 again.
Ah! Deleting previously updated translations (that are outdated meanwhile) fixed the issue (and so would a factory reset)
Was fixed near 12 H, but broken for now for fhe French language. (Working for English US)
Tested on 2 PC, Windows 10 and Widows 7:
- OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.0.0.4520, revision: 0c8121b
- OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.0.0.4520, revision: 0c8121b
(After factory reset and deleted all previous downloaded packages)
Works just fine in the new beta for me, but there only very few languages are to be updated curently
Edit: actually no, it doesn't work, it still fails for some, but less than before
Actually it is failing for 14 languages currently and for me
In reply to Works just fine in the new… by Jojo-Schmitz
Has worked this morning 8 H for Beta 3 and last Nightly for languages French and English US.
Not tested for others languages.
Works for French and English US, yes, but not for 14 others, like Asturianu , Dansk, Finnish, Japanese...
Right now it works for all languages
Looks like a collision between 3.0beta3 branch and master branch translation files... Note for myself, disable translation operations in release branches...
Currently it fails again, for some 16 languages
Still/again the case, for 3.0 RC, 6 languages fail to update
Again, I forgot to disable strings push in the rc branch :( brown bag.
Still/again happens for the released version
not sure what info is needed? It still happens
Ok, it is always reproduced, but genesis of the bug is absolutely unclear :(
Still the case. It does download the zip archives for those, but these archives' content is older than the files that the release has built in, except for the tours, i.e. mscore_LOCALE.qm and instruments_LOCALE.qm is older that what came bundled with MuseScore, just tours_LOCALE.qm is newer.
This is true for all 6 locales that it fails for currently: ar_EG, ca@valencia, gd, he, hy and lt, for MuseScore 3.0 release, and additionally hi_IN, ls and th for a self built from current master.
There are 3 distict conditions under which the error message "Failed, try again" gets put into those update buttons:
!dl.saveFile()i.e. the download failed. Apparently not the cases here as the zip files exist.!verifyFile(localPath, hash)i.e. opening and reading the archive and comparing the hash values for the local and remote files fails.!f.open(QIODevice::WriteOnly)i.e. unpacking the archive failed. As it can get unziped manually, this seems unlikely.Stepping thru under debug shows that indeed #2 is the failing case, so inside verifyFile() the hash comparison returns false (the opening of the archive succedes
They all work now, very strange
as translation updates have just changed to no longer going to 3.0, but to 3.0.1 (which is due shortly), and in 3.0 all translations available so far can get updated now, I'm marking this fixed (in the hope it doesn't crop up with 3.0.1 again)
Nope, issue still exists, with the latest development builds and currently 5 locales, ca, cs, ga, gd and gl
now it works for cs, but still fails for the other 4, ca, ga, gd and gl
In reply to now it works for cs, but… by Jojo-Schmitz
JoJo, could you debug the resourcemanager.cpp code and find the string which fails? The code is straightforward, so it shouldn't be a problem. I can try some tweaks on S3 side meanwhile...
inside verifyFile() the hash comparison returns false for those locales mentioned
Whatever you did on S3 (did you?) seems to have fixed the issue, I can now update all translations in the latest bdevelopment build (and MDL is back too)
In reply to Whatever you did on S3 (did… by Jojo-Schmitz
I did nothing related to languages since my comment. I added (obsolete) MDL packages this morning.
I suspect the tx2s3 script doing something wrong when transferring files... or writing data.json.
seems fixed
It s back and worse than ever before (far more languages), for 3.0.2
Also the recently added Filipino is missing from resource manager, but is listed in the Preferences/Languages choice
In reply to It s back and worse then… by Jojo-Schmitz
I think I know the reason. I'll check the hypothesis tomorrow. I usually create new directory on S3 for the new version and don't copy files from the previous one. The files then are pushed by tx2s3 script but only for updated languages. It explains undefined nature of the bug.
Any news on this? As far as I can tell it got even worse, almost all languages fail to update now
works again. as we still don't know why, I'd rather not mark it fixed
Let's close it