Incomplete function declaration in read206.h

• Mar 18, 2019 - 22:44
Reported version
3.0
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
MuseScore

The declaration and definition do not match, see here:
https://github.com/musescore/MuseScore/blob/b3adb50bd655bc943c502af8d6d…
and here:
https://github.com/musescore/MuseScore/blob/b3adb50bd655bc943c502af8d6d…

It's a simple fix to the .h file. The PR will be ready momentarily.

Comments

• Mar 19, 2019 - 08:05

This only worked BTW because that readTextStyle206() gets only used in read206.cpp and only after its definition (which also is a declaration).
The declaration in read206.h is pretty superfluos here, it just tells the compiler that there also is a method of that name with just 2 args, somewhere out there.

Reply

• Mar 20, 2019 - 13:30
Status PR created ⇒ fixed

The pull request was merged but this is issue was not closed automatically due to a missing space between "fix" and "#286294" in the commit message.

Reply

• Mar 20, 2019 - 14:49
Status fixed ⇒ closed

Once again, I had no idea that a space was required. Sorry about that. I'm closing it manually now and fixing another PR's commit message soon.

Reply