Deleting staff type change does not update score

• Apr 17, 2019 - 03:39
Reported version
3.0
Priority
P1 - High
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

In 3.0.5 and master:

1) new score
2) add staff type change to some measure after the first
3) use Inspector to set "small"
4) delete the staff type change

Result: staff is small from that point. As far as I can tell, there is simply no code to handle this at all. The stafftype element is never removed from the list internally. But, because the staff type change element is gone, it doesn't get written to the file, so it's fixed on reload.

I discovered this working on related code and am working on it along with a bit of other refactoring.


Comments

Related issue: while undo of adding a staff type change appears to work (the icon disappears), the stafftypelist is not updated, so it still acts like it is present. Meanwhile, if you add a staff type change mid-score, then undo, then try changing staff properties globally, it will only take effect up to the "zombie" staff type change.

Fix version
3.1.0