Use correct velocities on dynamics imported from MuseScore version 2 files

• Jun 8, 2019 - 16:03
Reported version
3.1
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
PR created
Regression
No
Workaround
No
Project

See discussion at https://musescore.org/en/node/290470.

This is basically how a dynamic with text before is entered into version 2

        <Dynamic>
          <subtype>other-dynamics</subtype>
          <text>poco <sym>dynamicForte</sym></text>
          </Dynamic>

For import from version 2:
If a velocity is explicitly set, it should be used as is currently the case.
Since, for an edited dynamic, the subtype is "other-dynamic" a test should be run to check for dynamic symbols, in this case "dynamicForte". Once a second one is found, then I agree the velocity, if not explicitly set, should be set to zero, but if only one dynamic is found then the velocity should be set to its default rather than zero.

I consider this a major issue because there are a lot of "subito p" type dynamics out there and their velocities are all being set to 0 on import.


Comments

Title Use correct velocities on dynamics imported from MuseScore version 2 files Import velocities from MuseScore version 2 files

So something we need in read206.cpp, i.e. for 2.x scores only?

I would say yes to read206.cpp since I don't know the MuseScore code. The problem with your title is that the velocities are not in the version 2 score in this one situation. All others I tested have a velocity listed in the score to include dynamics with text after and any dynamic, including these, with an explicit velocity change.

Title Import velocities from MuseScore version 2 files Use correct velocities on dynamics imported from MuseScore version 2 files

I didn't intend to change the title