Palette elements are deleted without any confirm message on palettes created in older versions
Reported version
3.4
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
active
Regression
No
Workaround
No
Project
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.4.2.9788, revision: 148e43f.
- Chose a palette with at least one customised symbol in it.
- Delete the symbol.
Expected result: "Are you sure?" window opens, giving user a choice of either archiving the symbol in "More" or deleting permanently.
Actual result: The symbol is permanently deleted without confirmation. No trace in the "More" archive.
Comments
The more menu only show those elements currently not shown but available in the master palette. As you can't add elements to the master palette, this is by design
There is still an issue here: there should be a confirm message before deletion to prevent loss of custom elements.
I can't reproduce in 3.5 beta, can you? If so, please provide more details. Might be necessary to save and attach a palette file, but maybe more important, describe the exact steps you are taking to delete the symbol. But I get the expected dialog with a choice between hiding or deleting permanently.
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.5.0.12237, revision: b5add95
Same in 3.5 beta. The issue of no delete confirmation dialogue is happening in all workspaces—preset, preset customised, or new customised. Tried resetting workspaces; using "single open" and "multi-open" palette options; tried "Revert to factory settings": No effect. Tried all forms of delete: right click menu, keyboard [Delete] key, and palette trashcan icon. No confirmation dialogue with any of them.
I still can not reproduce. Can you attach the specific palette you are deleting from, and tell us which element you are deleting?
Until a developer has confirmed they can reproduce the issue, please leave it as “needs info”.
It happens with all symbols (preset or custom), in all palettes, in all workspaces.
As mentioned, this is by design for the built in symbols. Only custom ones would normally triggers the dialog. and they do for me. So again, in order to investigate, we need info on how to reproduce, and that might start with a sample palette.
After more testing, it seems that if I create a new palette and populate it with custom symbols, the delete confirmation dialogue comes up as expected. The problem of no delete confirmation occurs with pre-existing palettes (e.g. see attached) which contain customised symbols.
(Note: I back up my .workspace file, and have restored it occasionally to "App data … Workspaces".)
I can reproduce using this palette, but I am not sure how it was created. What do you mean by "pre-existing"? Do you mean one you created yourself in an earlier version of MuseScore that did not support the current method of customization? That would make sense if so - we would have no way of differentiating this - and this could then be closed as by design. But if you mean one of the preset palettes built in to MuseScore, again, I cannot reproduce this. We'd need precise steps - like tell us which builtin palette you are customizing, attach a score you are using and which marking you are adding to that palette.
The symbols were originally created in an MS 2 but because MS2 workspaces cannot be imported, I had to reimport the MS2 palettes individually into an earlier version of MS3 to recreate the original workspace. It looks as if a more recent update to the workspaces may have created a back-compatibility issue with symbols added to palettes before the workspace update.
Another discovery: if you add one of the problematic symbols to the score and reimport into the palette, this revives the delete confirmation dialogue.
OK, so I have changed the title to reflect my understanding of the issue. What I suspect is happening is that the new palette format has a way of differentiating builtin from custom cells (a "custom" tag in the XML) and palettes created in older version simply lack this information, so we can't tell this is in fact a custom cell. Offhand I don't see a way to even detect the palette was created in an older version - it's MuseScore 3, just a too-old version of MuseScore 3. So there probably isn't a way to fix it, but it's worth logging this for future reference anyhow.