In Preferences -> Import : Action of Checkbox 'Always suggest to apply improvements...' is inversed

• Dec 16, 2020 - 05:56
Reported version
3.x-dev
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

In 3.6 Public Beta and 3.x OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.6.0.423676596, revision: github-musescore-musescore-

Always_apply.png

When checkbox 'Always suggest to apply improvements...' The Improvements dialog never appear.
When checkbox is unchecked, the improvement dialog appear.

The action of the checkbox is reversed.


Comments

I did not know that setting existed :) How did it get there?

It looks to contradict the options provided in the dialog. We should just clean this up for the Release Candidate

The name of that setting may explain this: #define PREF_MIGRATION_DO_NOT_ASK_ME_AGAIN                  "import/compatibility/do_not_ask_me_again" So it seems the Text in the dialog is backwards and should rather be "Never suggest to apply improvements..."

Introduced in 583c71cd50, before that it was #define PREF_IMPORT_SCORE_MIGRATION_ENABLED                 "import/compatibility/score_migration_enabled", so it indeed looks liike it had just been forgotten to invert that text in the dialog

Fix version
3.6.0