The 'Custom' string in 'Instrument > Order' shows untranslated

JLWaltener

• Jan 13, 2021 - 07:30

Reported version

3.x-dev

Type

Wording/Translation

Frequency

Few

Severity

S3 - Major

Reproducibility

Always

Status

closed

Regression

Workaround

Project

MuseScore

In 3.x (and same in 3.6 RC) OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.6.0, revision: a8b24cf

The 'Custom' string in 'Instrument > Order' shows untranslated.

Instruments Order.png

Signaled in the translators chat on 30/12/2020 https://t.me/MuseScoreTranslation/6080
Added to Trello https://trello.com/c/3WqHNe2s/88-the-custom-string-in-instrument-dialog…

Still the case in OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.6.0, revision: 7ead81d

Comments

Jojo-Schmitz

• Jan 13, 2021 - 09:00

I think this has got to do with the fact that this string is set in the contructor of the ScoreOrder class, and as such probably before the translation engine is ready.

JLWaltener

• Jan 13, 2021 - 09:07

I entirely trust you :)
and certainely difficult to fix.

njvdberg

• Jan 13, 2021 - 10:50

Yes, because the score order list expects this Custom is always available. That's why it is created when the score order list itself is created. And the score order is created "statically".

Jojo-Schmitz

• Jan 13, 2021 - 11:01

Well the list does get completed, i.e. all members but "Custom" get added later, so all those are getting translated. So the solution would be to do the translations at the time the list gets completed, or even only when it gets shown, rather than when it gets initialized, first created.

Jojo-Schmitz

• Jan 13, 2021 - 11:22

Strange though that for other classes' constructors the translation does work, like for InstrumentWidget() (which does call the constructor for ScoreOrderListModel, which in turn calls the constructor for ScoreOrder).
So being done inside a constructor apparently is not the cause.