Creating a 1/128 time signature result in 3/0 score

• Sep 28, 2010 - 13:37
Type
Functional
Severity
3
Status
closed
Project

MuseScore 0.9.6.3

  1. Create a new score
  2. In the score wizard choose 1/128 as the time signature
  3. Finish

Expected result: a (weird) timesig of 1/128 is expected in the score
Actual result: In the score, the time sig is 3/0

Side bug: In the time signature palette (T) It's not possible to have a denominator > 63.


Comments

Severity

The values are limited to 6 bit by design (1-63). R3524 limits the time signature wizard inputs to this range.

Severity
Status (old) fixed active

63 as a denominator does not work in the new wizard. I guess it shouldn't be allowed if we stay on 6 bits and we should use only 32 as the maximum (at least in the new score wizard)

in r3560/3561, the denominator of timesig is limited to 32 in new score wizard and measure properties actual duration.
I'm not sure what to do with the timesig (T) windows, should we authorize denominator between 33 and 63, how MuseScore will deal with this kind of timesig ?

windows xp - r.a3d5580

Now, the 1/128 signature on the wizard becomes 1/1 on the score.
However, you must introduce thr 128 value manually.
About the irregular denominators (33, 34, 55...) I think they should simply not be allowed.

Manually adding the value of the denominar with the keyboard should simply be forbidden.
You should be able to choose only between a series of preestablished values: 1,2,4,8,16, and 32.

Severity
Status (old) active patch (code needs review)

Here's what I think that could fix this.
It changes the current denominator textbox by one of those in which you must select from a number of options. Inputting any other value would thus be impossible.

In GitHub, go to: mscore/timesigwizard.ui

Select lines 77-82 and 166 -172 and change them for what's on the text file (paste both times the same text, the 2nd one is for the pickup measure).

My programming knowledge is very limited, but I guess that could work... If not, sorry.

Thanks,
G.

Attachment Size
fixure.txt 822 bytes

@guifre: you could get yourself an account in GitHub, fork MuseScore, make the change in your tree, sumbit it and then do a pull request for the core developers to have a look and accept it?

Well, I've done so...

However, as soon I made the pull request, I realized I'd done a couple of minor mistakes...
I've mentioned them in comments.
Sorry!!