[trunk r.3646] Clutter after end-start repeat sign (with patch)

• Oct 29, 2010 - 23:16
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

Steps: Load the attached sample score.
Result: After an end-start repeat sign, the space between the sign and the following note is quite narrow. In meas. 5, the accidental almost touches the repeat sign. With a simple start repeat sign, there is a little more room, but still too little.
Expected result: the repeat signs take some (or more than currently) room and the following symbols are moved to the right.

M.

Attachment Size
TestRepeat_r3646.mscz 1.45 KB

Comments

• Nov 19, 2010 - 00:51

Update: Start repeat sign is probably correct; issue remains for end-start repeat sign.

Analysis: issue seems caused by a difference between the element spacing used in bar line drawing (function void BarLine::draw(QPainter& p, ScoreView*) const in file barline.cpp) and in bar line layout (function void BarLine::layout(), same file).

The former uses:
*) 2 * dot width
*) 2 * thin line width
*) 1 * thick line width
*) 4 * end bar distance

while the latter uses only:
*) 2 * dot width
*) 1 * thin line width
*) 1 * thick line width
*) 3 * end bar distance

Patch: The attached patch corrects the void BarLine::layout() function adding the missing spacing elements.

Thanks,

M.

Attachment Size
barline_cpp_r3708.diff_.txt 716 bytes

Reply