Crash when removing added time signature if subsequent tie and rest in next measure
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
macOS Delete of time signature in any piece file size 70k or larger and the crash is very repeatable.
Attachment | Size |
---|---|
Crash-TimeSig-Delete.txt | 81.27 KB |
Comments
In order to investigate, we need an actual score and precise steps to reproduce the problem.
In reply to In order to investigate, we… by Marc Sabatella
Hi Marc
The crash is repeatable on macOS 10.14, Arch.: x86_64, MuseScore version (64-bit): 3.0.0., revision: e96bb9119b1b05bc1376d8f623c29410cef9a427. (Beta 2).
Method to cause the crash
Add additional time score anywhere on the score. saving or not has no effect. also happens opening up a file fresh with an additional time signature in it already.
to cause the crash .... Delete the time signature on the score.
Interestingly in looking for a file to demonstrate the crash the demo file all dudes included the beta causes the app to crash on attempting to open it!
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.0.0.4346, revision: a9203cb
Test file: test2.mscz
See:
Confirmed. As shown above, 4/4 score, add whole note, add 3/4 time sig in front thus changing it to dotted half tied to quarter, now remove the time sig. We end up calling qFatal() in checkRest(), range.cpp, so set your breakpoint there if you want to start debugging this...
First Successful crash capture I could get this morning with nightly build macOS 10.14, Arch.: x86_64, MuseScore version (64-bit): 3.0.0., revision: a9203cb
Yes, that is clearly the same problem cadiz1 describes.
See https://github.com/musescore/MuseScore/pull/4426.
Fixed in branch master, commit c73fdd3634
fix #279570: fix incorrect merging of tied notes on timesig change
Fixed in branch master, commit 79983705e5
Merge pull request #4426 from dmitrio95/timesig-crashes-2
fix #279570: fix incorrect merging of tied notes on timesig change
Automatically closed -- issue fixed for 2 weeks with no activity.