Repetition, 1, 2 and 3 doesn't work

• Feb 22, 2015 - 15:35
Reported version
2.1
Type
Functional
Severity
S4 - Minor
Status
closed
Project

I tested this example on musescore 2.0 beta2 and on the trunk.
I use musescore on fedora 21 64 bits.

I made a sample with 3 alternative repetitions.
When I play the score, the following sections are played: 1, 2, 2 and 3 instead of 1, 2 and 3.

Attachment Size
rep_problem.mscz 8.07 KB

Comments

I would have hard time to explain why, but if you right click the second volta -> volta properties -> repeat list -> and change 2 by 1. It works.

I had to read this and think about it a while to understand why this works. I get it now - you only want that second ending played the first time *for that particular end-repeat sign*. But of course, it's the second time for the repeat as a whole, which seems a more natural way to think about it.

So, is this a design we just need to document well, or a bug we plan to fix for 2.0?

is this a design we just need to document well, or a bug we plan to fix for 2.0?
This is a very good question... There is a test file repeat09.mscx which mention "volta set to 1" in the title of the score. So I would guess it was a design decision but except this, I have no other clue.

Hi, this just came up in the dutch forum as well. I have tested the workaround in 2.0.3 and that does not work anymore, it now even stops playing after the second volta when setting the second volta bar repeat count to 1. While testing I even noted a strange behaviour that it would play the 2nd volta AND start at the first bar of the repeat at the same time in playback (see attached volta-test file).
The case in the dutch forum is just a "simple" first, second and third ending.
So guess some more work needs to be done here.

Attachment Size
volta-test.mscz 4.08 KB

To be clear: what is described here isn't a "workaround", it's the correct behavior as we currently define it. No doubt there is room for improvement to make it more intuitive. But your file contains several errors. The repeat count for the measure with the first repeat is set to 3, when it should be 2, and the measure with the second repeat is set to 1 when it should be 2. Also, the volta repeats lists need to all be set to 1, because as explained above, the volta is to be played the first time *that particular measure* is encountered.

Fix these errors and it works as it should.

Status (old) patch (code needs review) fixed
Status fixed

Fixed in branch master, commit dd2050e2f1

fix #8604, fix #4525, fix #6091, fix #48456, fix #148276, fix #230531, fix #267778: improve volta playback
unwindSection using RepeatList as how a human will notate the volta: using the n-th time a startRepeat is taken, also slightly modified the jump detection logic to have it check for jumps only upon the last passage of a measure

Status (old) patch (code needs review) fixed
Status fixed

Fixed in branch 2.2, commit aaf88ffeb6

fix #8604, fix #4525, fix #6091, fix #48456, fix #148276, fix #230531, fix #267778: improve volta playback
unwindSection using RepeatList as how a human will notate the volta: using the n-th time a startRepeat is taken, also slightly modified the jump detection logic to have it check for jumps only upon the last passage of a measure