When changing to C-Major/a-minor after multimeasure rest, naturals are not shown/saved
Create a score which some non C-Major/a-minor key sig, add a C-Major keysig in a later measure and some notes, and yet another keysig even later, enable multimeasure rests, result:
I.e. the naturals are shown.
Save, close, re-open (or take attached sample score), result:
I.e. the naturals are lost.
Works as expected in 2.1, so is a regression in 2.2, and still exists in the current 2.3
| Attachment | Size |
|---|---|
| test.mscz | 3.24 KB |
Comments
This issue occurs on December 19, 2017
This nightly works 30a908c
Not this one: so here: a09f8e2
To fix: #251706: Changing key signature after section break on horizontal frame force a courtesy key signature.
Or the previous? : https://github.com/musescore/MuseScore/commit/9d784dda31b721e91af2cc687…
To fix: #267602: Measure shifts back and forth with each layout
EDIT: it's the same commit for the two issues.
Hmm. This commit also seems to be responsible for another regression, a case of one score that did not have a layout shift problem in 2.1 but does in 2.2.1. Thus, the change actually caused the very problem it was trying to fix in that particular case, as per my comment in https://musescore.org/en/node/267602#comment-831071. And that particular fix was 2.x-specific - it was never merged for master, because master was sufficiently broken with respect to key signatures (naturals not displaying at all) that it was impossible to test in any way. Not sure if that's still the case. I wouldn't expect the same test cases to necessarily show the problem on master because it is so dependent on the exact widths of things, and that surely has changed a lot.
Anyhow, I think we should consider reverting that particular change, then going to master and getting key signatures with naturals to work again (if they don't), and then readdressing #267602: Measure shifts back and forth with each layout in light of these regressions, so we come up with a fix that doesn't also break those cases.
I have dealt with quite a few of these sorts of layout-shifting issues over the years, and I can say they are no fun to debug. If someone else wants to take a crack, I'm more than happy to share my insights, maybe we can discuss over IRC?
Working on this too along with #267602: Measure shifts back and forth with each layout
See https://github.com/musescore/MuseScore/pull/3753. Note the PR is against 2.3, but the same code should apply to master if/when my original PR https://github.com/musescore/MuseScore/pull/3356 gets merged for master as well.
Fixed in branch 2.3, commit 46bd6f6832
fix #272691: no naturals in key sig after mmrest
In reply to See https://github.com… by Marc Sabatella
Hey there :)
I have very little understanding of coding and software development, so I though I'd just ask it here instead of reading the code in the link below this comment.
Is there an estimated time we can expect an update on the naturals in multimeasure rests problem? I'd like to export a piece of mine, but I'll wait until this problem is fixed because multiple parts experience this problem.
Thank you in forward! :)
Greetings
As the comment right above yours indicates, this is "Fixed in branch 2.3" - which is planned for release "any day now". Feel free to downlaod a nightly build using the "Download" menu above if you'd like to help test today!
Automatically closed -- issue fixed for 2 weeks with no activity.