MS3: Line color not being saved.

• Jan 21, 2019 - 19:17
Reported version
3.0
Priority
P0 - Critical
Type
Graphical (UI)
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
MuseScore

OS: macOS 10.14, Arch.: x86_64, MuseScore version (64-bit): 3.0.1.20439, revision: 06a66a2

Make a "note anchored line" (or any line as far as I know). Set its "line color" (and its "element color" -- what is this?) to Maraschino/red. Save the file. Close it. Reopen it. The lines are black/Grey.

Attachment Size
line_test.mscz 5.31 KB

Comments

• Jan 22, 2019 - 21:50
Regression No ⇒ Yes
Priority ⇒ P0 - Critical

Confirmed. Could be a mismatch between the properties for the line and for the line "segment" (since lines can continue across systems, each segment has its own properties for things like offset and color). Which also suggests that at the same time, we should probably consider making the element color automatically propagate to the correct line / segment properties so it doesn't just sit there doing nothing.

Reply

• Feb 18, 2019 - 11:26

I suggest that we get rid of the 'line colour' property altogether, and just use the normal Pid::COLOR (which is what 'element colour' is linked to) to set the _lineColor of a Line. I'd keep the 'Line Color' field in the inspector textlinebase though, just instead of linking it to Pid::LINE_COLOR, it'd be linked to Pid::COLOR.

Reply

• Feb 18, 2019 - 11:48

Did you delete your comment? I'll respond anyway: the top colour field is one that exists for every element in the score, text, notes, barlines, etc. The bottom colour field is one specific to lines. Looking through the code, I don't see any reason why we can't get rid of the bottom colour field, and just link up the line's colour attribute to the top colour field instead. So, that's what I'm doing. I'll submit a PR in ten minutes or so.

Reply

Fix version
3.0.3