Option to always have album add PageBreaks in addition SectionBreaks before each movement

• Apr 11, 2016 - 19:10
Reported version
2.2
Type
Functional
Severity
S5 - Suggestion
Status
closed
Project
Priority (old)
minor
Status (old)
closed
Component (old)
Code
Category (old)
feature request

Just something I find that I always end up needing to do, so I'd like to add an option to do it automatically. Should the option be in preferences or in the AlbumManager ui?


Comments

Thanks Jojo. I see you had already raised the request: "and maybe a page break optionally" there .

I'm wondering if in addition to adding option for PageBreak which would be OFF by default, to also add an option for SectionBreak which would be ON by default (to be consistent with current behavior).

Sound good to me. Not sure how to deal with cases where a section or page break already exists at the end of the score to join, something to check out.

I've modified the AlbumManager ui as follows:

Album_Manager_option_join_scores.png

Note those checkmarks are at the their default position. I chose to use a QGroupBox in order to keep the options for saving a joined score to be isolated from the "Print Album" button, so that it is clear that those options only affect the "Join Scores" button. Hypothetically, could add a seperate set of options for "Print Album".

Not sure how to deal with cases where a section or page break already exists at the end of the score to join, something to check out.

I would say that those checkmark options I have are only adding breaks - i.e. they will not remove breaks. So if none of them are selected, then if there is already a break at end of score to join, then whatever break was already at the end of that score will persist. I think this would be self-evident if use the wording "add".

yes, I guess that's true. The button texts probably need to get changed slightly, to match the proper casing style, "Add section break" and "Add page break", I think.

Status (old) active patch (code needs review)

I submitted a PR for review: https://github.com/musescore/MuseScore/pull/2536

This is what my AlbumManager ui looks like now:
Album_Manager_option_join_scores_full-phrase.png
Notice I'm using full phrase "Add [section/page] break between scores". That might be a little more wordy than "Add section break", but I was wasting time debating with myself whether "break" should be singular or plural, so I just wrote out the full phrase.