[Trunk] Instrument short and long names are not imported for 1.1 scores

• Nov 27, 2011 - 16:50
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

Hello,

Short and long name in 1.1 score are not imported in 2.0

Regards

Gai-Luron

Comments

• Nov 27, 2011 - 19:17

Confirmed :).

It could possibly apply to other scores that weren't produced in 1.1 (e.g. 1.0) though.

Using MuseScore 2.0 Nightly Build (5051) - Mac 10.6.8.

Reply

• Nov 27, 2011 - 21:44

Hello,

Fixed in this patch. Import style from 1.1 is different now. _Doc is deleted in setstyled.

Use plainText instrument name instead Html one ( seems to be obsolete)

Bye

Gai-Luron

Attachment Size
InstrumentName.patch 1.02 KB

Reply

• Dec 1, 2011 - 11:50
Status (old) patch (code needs review) ⇒ fixed

fixed in r5060. Instead of changing Text->getFragment() into Text->getText() i choosed to fix Text->getFragment().
Html is not obsolete but used for unstyled text representation. Styled text is much simpler and uses the new SimpleText class. This avoids the overhead of QTextDocument for simple text like lyrics etc. The implementation of instrument names probably needs another iteration to make better use of this lightweight class.

Reply