Applied changes should revert if user presses cancel

• May 9, 2009 - 23:03
Type
Functional
Severity
3
Status
by design
Project
  1. Open score
  2. Layout > Page Settings...
  3. Make some changes to the page settings and press "Apply"
  4. Cancel out of the dialog

Expected behavior: All changes made should revert back to previous state when you press Cancel

Actual behavior: All changes remain in effect.

This same behavior happens with the Page Settings dialog, the Edit Style dialog, and the Edit Text Style dialog.

(Tested using r.1812 and v0.9.4, Windows XP)


Comments

Severity

David: I'm perusing some of the old bug & features requests and I realize this is a _very_ old request but the behaviour you're noting when using Apply is normal, at least for Windows. If I make a change (say in a Control Panel window) without clicking Apply and click Cancel instead then the changes are ignored. If I click Apply first then there's no backing out even though the Cancel button is still available.

I haven't checked but do some/any of MuseScore's option/prefs/popup windows (that have an Apply button) work the way you want them to (the expected behaviour)?

Although I can't find a specific example at the moment, in my experience it is fairly common for the Cancel button to be unavailable (grayed-out) after the changes have been applied. An additional change in the dialog enables the Cancel button again, but it only discards the changes since the Apply.

Severity
Status (old) active by design

I can't find any examples of any programs on Windows that do either of these things. That is, Apply is never revertable via Cancel, and Cancel is never greyed out. The only button that typically changes state according to whether there are pending changes is Apply. If Cancel were disabled when there were no pending changes, then all dialogs would initially come up in this state, and you wouldn't be able to hit Esc to close them until.

If someone finds not just an outlying example but some sort of clear statement in a Windows, MacOS, or Linux style guide that this behavior is actually correct, feel free to reopen this. But as far as I can see, MuseScore acts just as every other program I can find that includes Apply buttons.