Move Metronome out of Synth because Metronome's volume and it's mute status are not saved/loaded from score or default.
On 2.0.3 and 3.0-dev 4a3864d if the Synthesizer window, if you change the master volume or any settings in the QTabWidget, the "Save to Score", "Load from Score", "Set as Default", and "Load Default" buttons will do exactly what they say.
However, the metronome's volume slider and its mute button are also on the same window, but are not saved/loaded to the Score or as Default when the corresponding buttons are pressed.
I consider this a bug because the Synth's .ui has the metronome slider and mute button inside it.
Comments
This means SynthControl::updateGui() will need to set the gain for the metronome same time it performs setGain(synti->gain());
and the metronome gain and on would have to be added to MasterSynthesizer::state()
I've been thinking that maybe there is a deliberate reason why the metronome is not saved to synth (maybe because when exporting scores to audio, probably don't want metronome anyway, but since the current code uses the synth settings for export, we might not want to confuse that export).
Anyway, I'm thinking that putting a QGroupBox around the properties that are saved would distinguish it from the properties that aren't saved...I'm going to submit a PR for this solution since it is easiest (and less debatable).
Well I tried putting everything but the metronome inside a QGroupBox. But I didn't like it, because the groupbox boundaries means the window takes up more space, and it just looked asthetically bad to have the metronome all alone by itself.
SO now I'm thinking of just removing the metronome from this .ui entirely, because it doesn't belong. This would revert some parts of https://github.com/musescore/MuseScore/commit/f471d311786f2451f38c459e3… which was the commit which added the metronome to the synth ui.
https://github.com/musescore/MuseScore/pull/3086
Fixed in branch master, commit 3d7b3f781c
fix #182546 #182176 Move Metronome to PlayPanel
Moving the Metronome out of the Synth and into the PlayPanel fixes two problem:
182176 Synthesizer Metronome button not lined up with Metronome vol slider if adjust right edge of window.
182546 Metronome's volume and it's mute status are not saved/loaded from score or default.
Moved the metronome button and count-in button to be under the metronome volume slider.
Fixed in branch master, commit 0d76609cab
Merge pull request #3086 from ericfont/182546-RemoveMetronomeFromSynthUI
fix #182546 #182176 Move Metronome to PlayPanel
Just making a note to posterity that basically the way I "fixed" this issue was by removing the metronome from the Synth window, that way the buttons in the synth window do indeed affect everything on the Synth window.
Automatically closed -- issue fixed for 2 weeks with no activity.
hi, if it's removed, from where could we adjust/control metronome volume?
there is a NEED to keep it somewhere, possibly the play panel? and make it default volume 60% of the score play volume?
Xianyue, the metronome relative tempo & volume controls are will be in the Play Panel for MuseScore 3.0. That is where they most appropriately belong...and it is better now that the metronome controls are all together in one UI.
thanks jazz, pls write in developers memo, pls user asks/prefers/requests/need the settings on play panel remain the same when open a new score in the same app, or reopen the app. to adjust every score to the same speed, volume is not easy, pls help to retain consistency.