Mismatch between "To Coda" and "Fine" when the first is deleted before enable mmrests

• Jun 18, 2017 - 17:12
Type
Functional
Severity
S2 - Critical
Status
PR created
Regression
No
Workaround
No
Project

2.1 version 871c8ce/ Windows7

1) New score
2) From the repeats palette, add "To coda" and "Fine" some measures after.

- Test file at this step: Fine.mscz
3) Press M
Result: as expected
4) Press M again
5) Cut "Fine"
6) Press M last time

Result: unexpected: "Fine" is always showed and steals the place of "To Coda"
Fine.jpg

- Same behaviour with reverse case: To coda first, then Fine: To coda.mscz
And so with same steps (M twice -> cut "To coda" -> M): same surprising result: To coda displayed, not Fine.


Comments

Issue discovered by working about this issue: #224031: Crash by undoing the removal failure of the repeats palette symbols separating multimeasure rests
And without knowing how/why, I note that the change of February 25, 2015, is involved too (https://musescore.org/en/node/224031#comment-737261)

Ie, with this nightly, all results - when Fine or To Coda are cut after the mentioned steps upper - are expected: 781c5b7
- With this one, one can observe the change and current result: 94ad084

Severity S4 - Minor S2 - Critical
Status active PR created
Reported version 2.1  
Regression No
Workaround No

Here is another scenario:

  1. New score
  2. Add a Segno and a “Fine” some measures later
  3. Press M
  4. Press “M” again
  5. Delete the “Fine”
  6. Press “M” on more time. You will see that the Segno has disappeared and the “Fine” has been moved to the end of the score.
  7. Undo four times.
    At this point, MuseScore will crash.

The crash is the direct result of 6118f88, which was meant to fix #224031: Crash by undoing the removal failure of the repeats palette symbols separating multimeasure rests. But that commit did not fix the original issue, which was that the marker could not be deleted when mutimeasure rests are enabled. See https://github.com/musescore/MuseScore/pull/5145 for a patch that reverts 6118f88, fixes the original issue described in #224031: Crash by undoing the removal failure of the repeats palette symbols separating multimeasure rests, and fixes this issue as well.