Bold, italic, underlined etc. applied to wrong selection; may lead to crash

ABL

• Mar 18, 2014 - 16:27

Type

Functional

Severity

S2 - Critical

Status

closed

Project

MuseScore

Steps:
1- Open attached file;
2- Double-click on the text;
3- Select the word "Long";
4- Press "bold" button, or Ctrl+B;
5- Repeat step 4 -> the word "Long" is still bold;
6- Repeat step 4.

Result:

Expected:

It can lead to crash:
1- Open attached file;
2- Double-click on the text;
3- Select the word "Long";
4- Press "bold" button, or Ctrl+B;
5- Press "italic" button, or Ctrl+I -> other letters, not the selected ones, become bold;
6- Press Esc or click outside the text -> crash.

Windows 8.1, Nightly build e6a2034

Attachment	Size
text_double_font_change.mscz	1.34 KB
expected.png	10.87 KB
result.png	11.2 KB

Comments

ABL

• Mar 18, 2014 - 16:40

A typo in the previous steps:
5- Press "italic" button, or Ctrl+I -> other letters, not the selected ones, become ~~bold~~ italic;

shredpub

• Mar 18, 2014 - 19:05

It does not crash on my version which is around a week old. Also, I am using Ubuntu.
However, the text is not changed to italic/ bold either. No effect is seen whatsoever.

System Message

• Mar 18, 2014 - 20:26

Status (old)

active

⇒

fixed

Fixed in 3be4253216

ABL

• Mar 19, 2014 - 09:17

Status (old)

fixed

⇒

active

Unfortunately, the crash part is still active, because it is probably a different bug with respect to the "applied to wrong selection" part.
Steps:
1- Open previous file;
2- Double-click on the text;
3- Select the word "Long";
4- Press "bold" button, or Ctrl+B;
5- Without exiting text edit mode, press "italic" button, or Ctrl+I;
6- Press Esc or click outside the text -> crash.

Attached the log from gdb (from a personal build under Linux Mint).

Windows 8.1, Nightly Build 9cde62c.

Attachment	Size
double_change_crash_log.txt	5.16 KB

System Message

• Mar 19, 2014 - 10:38

Status (old)

active

⇒

fixed

Fixed in 690de2fb55

schepers

• Mar 19, 2014 - 13:04

Pressing Superscript on selected text (title, system text) always crashes for me. I can make it crash after some combinations including subscript.

Jojo-Schmitz

• Mar 19, 2014 - 13:13

Status (old)

fixed

⇒

active

confirmed. and strangly only superscript, none of the others ?

schepers

• Mar 19, 2014 - 13:24

No, I was able to make it fail on other random combinations, usually including subscript. The three normal ones (bold, italic, underline) do work better than yesterday.

schepers

• Mar 19, 2014 - 13:44

I find any combination of bold/underline/italics with subscript will crash.

Kim SJ

• Mar 19, 2014 - 17:33

Yup, crashes for me too. (abfb11136d3ac02d600fbc64aeef0eb6b414b285/Ubuntu 13.10)

[DELETED] 3

• Mar 20, 2014 - 08:01

4f67214a09 tries to fix this.

ABL

• Mar 20, 2014 - 10:44

I can still see the crash in a357ccb self-build under Windows 8.1 and Linux Mint 13.
It always crashes when using superscript.
It crashes when using bold, italic or underline + subscript (subscript alone works fine).
Attached the gdb logs for the superscript and bold+subscript cases.

In the superscript case at #6 of the log it says:
Ms::XmlNesting::popToken (this=0x7fffffffca90, t=0x1cfdde0 "sub")
shouldn't it be "sup" instead of "sub"?