Identical logical conditions in libmscore/rest.cpp lines 197 and 207 maddin200 • Oct 12, 2017 - 17:36 Reported version 2.1 Type Functional Severity 3 Status closed Project MuseScore \libmscore\rest.cpp line 197 || (type == ElementType::STAFF_TEXT) Reply Comments Jojo-Schmitz • Oct 12, 2017 - 17:47 Good catch, libmscore/rest.cpp, line 197 and libmscore/rest.cpp, line 207 are indeed duplicates. I'd remove the latter Reply Jojo-Schmitz • Oct 12, 2017 - 18:24 Title Identical logical conditions ⇒ Identical logical conditions in libmscore/rest.cpp lines 197 and 207 Severity ⇒ Reply Jojo-Schmitz • Oct 13, 2017 - 14:29 Severity ⇒ Status (old) active ⇒ patch (code needs review) Status active ⇒ See https://github.com/musescore/MuseScore/pull/3313 Reply Jojo-Schmitz • Oct 14, 2017 - 10:00 Severity ⇒ Status (old) patch (code needs review) ⇒ patch (ready to commit) Status ⇒ PR created Reported version 3.0 ⇒ 2.1 issue and fix apply to master and 2.x Reply Git Message • Nov 16, 2017 - 16:37 Severity ⇒ Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 3a4b88081c Fix #258121: duplicate condition in libmscore/rest.cpp Reply Jojo-Schmitz • Nov 16, 2017 - 22:00 Severity ⇒ Status (old) fixed ⇒ active Status fixed ⇒ active Could go to 2.2 too Reply Jojo-Schmitz • Nov 16, 2017 - 22:17 Severity ⇒ Status (old) active ⇒ fixed Status active ⇒ fixed Ah, I see it is in 25f03fe Reply System Message • Dec 1, 2017 - 09:00 Severity ⇒ Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • Oct 12, 2017 - 17:47 Good catch, libmscore/rest.cpp, line 197 and libmscore/rest.cpp, line 207 are indeed duplicates. I'd remove the latter Reply
Jojo-Schmitz • Oct 12, 2017 - 18:24 Title Identical logical conditions ⇒ Identical logical conditions in libmscore/rest.cpp lines 197 and 207 Severity ⇒ Reply
Jojo-Schmitz • Oct 13, 2017 - 14:29 Severity ⇒ Status (old) active ⇒ patch (code needs review) Status active ⇒ See https://github.com/musescore/MuseScore/pull/3313 Reply
Jojo-Schmitz • Oct 14, 2017 - 10:00 Severity ⇒ Status (old) patch (code needs review) ⇒ patch (ready to commit) Status ⇒ PR created Reported version 3.0 ⇒ 2.1 issue and fix apply to master and 2.x Reply
Git Message • Nov 16, 2017 - 16:37 Severity ⇒ Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 3a4b88081c Fix #258121: duplicate condition in libmscore/rest.cpp Reply
Jojo-Schmitz • Nov 16, 2017 - 22:00 Severity ⇒ Status (old) fixed ⇒ active Status fixed ⇒ active Could go to 2.2 too Reply
Jojo-Schmitz • Nov 16, 2017 - 22:17 Severity ⇒ Status (old) active ⇒ fixed Status active ⇒ fixed Ah, I see it is in 25f03fe Reply
System Message • Dec 1, 2017 - 09:00 Severity ⇒ Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
Good catch, libmscore/rest.cpp, line 197 and libmscore/rest.cpp, line 207 are indeed duplicates. I'd remove the latter
See https://github.com/musescore/MuseScore/pull/3313
issue and fix apply to master and 2.x
Fixed in branch master, commit 3a4b88081c
Fix #258121: duplicate condition in libmscore/rest.cpp
Could go to 2.2 too
Ah, I see it is in 25f03fe
Automatically closed -- issue fixed for 2 weeks with no activity.