Languages

Crash when adding text to a ChordRest

mattmcclinch

• Jul 3, 2018 - 05:54

Reported version

3.0

Type

Functional

Severity

S2 - Critical

Status

closed

Project

MuseScore

When I try to add text to any chord/rest, MuseScore crashes.

This is a result of commit 6b8a6461f3 to fix #272380: Rehearsal marks from palette (B1) are not generated automatically.

The reason for the crash is that Element* e is assumed to be of type ElementType::REHEARSAL_MARK. This is not a safe assumption, because the cases for several other ElementTypes fall through to this point in the switch statement.

Comments

mattmcclinch

• Jul 3, 2018 - 05:59

Status (old)	active	⇒	patch (code needs review)
Status	active	⇒

See fix #273919: Crash when adding text to a ChordRest #3779.

Git Message

• Jul 3, 2018 - 12:28

Status (old)	patch (code needs review)	⇒	fixed
Status		⇒	fixed

Fixed in branch master, commit 848c5e44eb

fix #273919: Crash when adding text to a ChordRest

Git Message

• Jul 3, 2018 - 12:28

Fixed in branch master, commit 5de198136a

Merge pull request #3779 from mattmcclinch/273919-chordrest-text

fix #273919: Crash when adding text to a ChordRest

System Message

• Jul 18, 2018 - 10:00

Status (old)	fixed	⇒	closed
Status	fixed	⇒	closed

Automatically closed -- issue fixed for 2 weeks with no activity.