Tuplets are imported wrong from 2.X file so that notes are lost

• Aug 18, 2018 - 15:26
Reported version
3.0
Priority
P3 - Low
Type
Functional
Severity
S2 - Critical
Status
active
Regression
No
Workaround
No
Project

Tested with self built MuseScore on OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (32-bit): 3.0.0, revision: 44304ca

I set Major because the score is corrupted in particular place and initial notes cannot be recreated.
1. Open score
2. Go to measures 13 and 14
Result: compare the measures content in 2.3.2 and 3.0. Some notes have been lost.
triplet_incorrect_notes.PNG

Attachment Size
2807161.mscz 40.03 KB

Comments

Status (old) active needs info
Status active needs info

The problem does not seem to be with 3.0 but rather with the score you are testing this on. The original score is corrupt.

2807161 corruption.png

I noticed in the original picture that the second 3 in both measures was offset. I deleted the second triplet from the second measure and turned on all of the brackets for comparisons sake. Note that deleting the second triplet deletes interlaced notes. This isn't supposed to be possible. The bug more likely originated in version ~ 2.2 where tuplet import was supposed to be fixed, but led to this bug when opening previous scores caused tuplets to become corrupt.

In reply to by mike320

Status (old) needs info active
Status needs info active

Sounds interesting. The score looks correct and playback is as expected in 2.3.2. So, if 2.3.2 can open such corrupted scores, we need to reimplement this possibility in 3.0, because 3.0 should open 2.X scores without issues and make it even better with the new layout engine.

There is definitely something wrong with the original score. Somehow, during the saving of the score, the ordering got jumbled a little bit.

        <Tuplet id="3">
---snip---
          </Tuplet>
        <Chord>
          <Tuplet>3</Tuplet>
---snip--
          </Chord>
        <Chord>
          <Tuplet>3</Tuplet>
---snip--
          </Chord>
        <Tuplet id="4">
---snip--
          </Tuplet>
        <Chord>
          <Tuplet>4</Tuplet>
---snip--
          </Chord>
        <Chord>
          <Tuplet>3</Tuplet>
---snip--
          </Chord>
        <Chord>
          <Tuplet>4</Tuplet>
---snip--
          </Chord>
        <Chord>
          <Tuplet>4</Tuplet>
---snip--
          </Chord>

I have corrected the score (moved the final chord in tuplet 3 above tuplet 4, and did the same in measure 14), and it loads properly in 3.0.

Attachment Size
Nntendo_Medley violin 3.mscx 214.62 KB

In reply to by mattmcclinch

@Matt,

My intention was not at all to ignore the corruption but rather to point out that the corruption was cause by opening and saving it before version 3.0. I agree wholeheartedly that corruptions should be fixed when opened in newer versions. I also think the offending code should be found to ensure it is not propagated to version 3. I guess another question is what would happen if the 2.0.3.1 score were opened in version 3.0? Was the original 2.0.3.1 score what was seen in the 3.0 pictures?

I was going to do some testing of the original file in version 2.0.3 or version 2.1 but I can't seem to be able to find portable versions for these, only source code which I don't know how to build into an executable form. After further investigation, it seems that MuseScore.com corrupted the score when it converted the file from 2.0.3. If I could get the 2.0.3 or 2.1 portable I could attempt to recreate the bug.

I guess another question is what would happen if the 2.0.3.1 score were opened in version 3.0?
Can't you do this?
Was the original 2.0.3.1 score what was seen in the 3.0 pictures?
That was my understanding.

I do not know what caused the weird ordering that I mentioned a few comments ago, but is present in the original 2.0.3.1 score. Nested tuplets are allowed, but overlapping tuplets probably should not be allowed. It should not be too hard to check for this.

Well, I guess that depends on what you think is correct. I think MuseScore should complain about overlapping tuplets. Or else fix them. Version 2.3 does neither.

In reply to by Anatoly-os

@Anatoly,

Are you saying you opened the original score created in version 2.0.3.1 or did you download it from MuseScore.com which had converted it's format to the same as 2.3.x.

There is a HUGE difference between nested and interlaced tuplets. Nested tuplets are possible and often easy to reproduce on demand and at other times impossible. As an aside, I recently saw a request for an impossible nested tuplet because it was based on a note 5 16th notes long on the inside tuplet. This is not possible in MuseScore, but I guess you could alter the .xml and MuseScore would handle it without problems. Interlaced tuplets are not defined in music and should be impossible in MuseScore as well. As you saw from my pictures, the last note of the first triplet disappeared and the last two notes of the second triplet. This is an interlaced tuplet.

Finally, the old versions give you the option of a .msi file, which will not install on a windows system with a newer version of MuseScore on it without jumping through hoops I haven't had to jump through in the past. It also has a zip file that contains the source code. In the past, the zip file had the compiled portable version that did not care about the existence of other versions of MuseScore on the computer. I didn't check to see if the 2.2.1 zip still contains the portable, but I have a 2.2.1 portable that I downloaded from that page shortly after the release of 2.3.1. I don't remember if this was before or after the older version were moved.

“Interlaced” may be a better term than “overlapping” in this case, but we are talking about the same thing. We agree that these should not be allowed, but nested tuplets are fine.

In reply to by Jojo-Schmitz

Thank you Jojo.

I entered (copied) the score into the 2.0.3 portable and tried various other versions to see if I could duplicate the problem with the interlaced tuplets and it only happens in version 2.3.2. So we now know the bug was introduced somewhere between 2.3.1 and 2.3.2.

Mike, are you saying you have created a score in 2.0.3 that results in interlaced tuplets when loaded into 2.3.2? I would like to see this new 2.0.3 score. In the original attachment, the tuplets are already interlaced.

When I open that score in 2.3.2, the tuplets are not interlaced. Saving the score in 2.3.2 also does not cause the tuplets to become interlaced.

In reply to by mattmcclinch

FM! I created the score in 2.0.3, save it, opened it without saving it in 2.2.1 and 2.3.1 with no interlace. I then opened it in 2.3.2 and it was interlaced. I just tried it again and it's not interlaced in 2.3.2. I guess whoever is going to fix the problem will have to do what I did to figure out what's going on.

When I created it in version 2.0.3 copied everything but the two measures with the problem, which I entered from scratch to assure I did not copy the problem. I did the first 39 measures because I figured that was sufficient to reproduce the problem and there is a key change in measure 40.

I then opened it in 2.3.2 and it was interlaced.
You are absolutely sure about this? I can keep trying, but so far it always opens correctly for me each time.

In reply to by mattmcclinch

I don't know what I did different this time, the interlace is gone. As I said FM (f...ing magic if you don't understand). I have no idea what's going on. Since we know it happens sometimes, I guess all you can do is have version 3 look for the problem and fix it if it exists, unless someone has a better idea.

Opening the score resaved in MuseScore 2.0.3 results in correct tuplets processing. So, I'm reducing the priority to minor since the issue relates to one particular score. We can increase the priority once someone finds similar results.