Make the color of invalid/disabled options in the menus more distinguishable

• Jun 24, 2019 - 10:55
Reported version
3.0
Priority
P1 - High
Type
Ergonomical (UX)
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
Yes
Project
MuseScore

In the dark mode, the invalid option in the right-click menu is very similar with the valid ones. At first glance, it seems to be the same. This type of text should be changed to other distinguished colours.
截屏2019-06-2419.49.19.png

Or change the colour of shadow to black
mockup.jpg

Comments

• Jul 12, 2019 - 10:51
Title Make the Colour of Invalid Option in the right-click menu more distinguishable ⇒ Make the color of invalid/disabled options in the right-click menu more distinguishable

Reply

• Jul 22, 2019 - 18:56
Title Make the color of invalid/disabled options in the right-click menu more distinguishable ⇒ Make the color of invalid/disabled options in the menus more distinguishable

It is all menus

Reply

• Jul 23, 2019 - 13:06

Most likely a matter of setting up ...share/themes/style_dark_fusion.css, namely:

*:disabled {
 color: gray
}

Just how? I've tried about every possibpe permitation of colod, background, border and bkacl, gray, darkgrep etc. without success so far.

There's one strange difference between the light and the dark css file, only the light one has this part:

/* dock and main area separator */
QMainWindow::separator {
    background: #C8C8C8;
    width: 1px; /* when vertical */
    height: 1px; /* when horizontal */
}
 
QMainWindow::separator:hover {
    background: gray;
}

Omission (and not needed in dark theme) or on purpose?

Reply

• Jul 23, 2019 - 18:24

Hmm, after a log of trial and error and changing the settings shown above to this:

*:disabled {
 color: gray;
 background: #444444; /* some pretty dark gray, found be experimenting */
}

I can come up with this:
staff-properties-dark.png
I haven't been able to find a way to color the shadow of that text (text-shadow: black; doesn't work), or to set the background color for *:disabled without setting it for the enabled menus too

Reply

• Jul 24, 2019 - 14:56
Status PR created ⇒ fixed

Fixed in branch master, commit 5c372e9750

_fix #291233: make disabled menu entries more distinguishable in dark theme

Reusing the colors matcheing the setting for "Base" in palette_*_fusion.json. files. Changes for the light theme only for
symmetry, not strictly needed otherwise.
Syncing light and dark theme's settings, seems forgotten changes from back in 2016, fcb88e51
Some more syncing themes, sorting the json files the same way, which reveals that the dark theme has one extra setting, "Highlight", so adding the default color, Qt::darkBlue, for that to the light theme._

Reply

Fix version
3.3.0