Lines: Minimum distance is not saved with score unless it is part of the style
P1 - High
S3 - Major
- Open the attached score.
- Change the "Minimum distance" for all lines to Zero in the Inspector.
- Save and reopen the score.
Expected result: No change.
Actual result: The Minimum distances have reset to the style default.
Confirmed. Not sure what's going on., I would have sworn this worked when I first implemented it.
Well, it works if you change the offset, which is the usual way min distance gets changed. But not if you only change the minimum distance. So not quite as serious as it looked at first. Still, it's an easy enough fix. Just slightly tricky to create a good test for.
Fixed in branch master, commit b995287630
_fix #294728: min distance not saved for lines unless offset changed too
If you move a line into the skyline (e.g, overlapping other elements),
we reduce the min distance automatically and save the result correctly.
But if you reduce the min distance manually via the Inspector
but don't change the offset, then save, the min distance is not written.
That is because we check if the line has been modified before writing these properties.
But we were only checking offset and offset2, not min distance.
This change adds that check._
Fixed in branch master, commit cd8648ab74
_Merge pull request #5344 from MarcSabatella/294728-min-distance-save
fix #294728: min distance not saved for lines unless offset changed too_
Automatically closed -- issue fixed for 2 weeks with no activity.