Recent PR removes the ability for other windows to use MuseScore commands

• Apr 28, 2020 - 16:55
Reported version
3.x-dev
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
MuseScore

I've been working on the Piano Roll Editor and recently noticed that many of the buttons stopped working. I was able to trace the issue to this recent PR:

fix #101991 Ignore shortcuts in menus #5982

Essentially, the logic now says that only the main window can issue these commands. However, it would be useful for other widows to be able to issue commands too. It seems like a lot of extra work to rewrite the play, rewind, etc. commands for every new window that needs to use them. It also breaks how these buttons have worked in up until this PR.

Comments

• Apr 29, 2020 - 13:03
Status PR created ⇒ fixed

Fixed in branch master, commit 80644a7255

_fix #101991, fix #304586: fix menu mnemonics colliding with note input shortcuts

This commit reverts dbb79fad3e0df676556aa737a65fd39fada84f6e to avoid
interfering with cmd() invokations made not by pressing a letter key
in menu (e.g. from a Piano Roll Editor window). The solution applied
in this commit also makes menu mnemonics actually working thus
restoring their expected behavior._

Reply

Fix version
3.5.0