Crash when applying preferences with no scores open
Reported version
3.x-dev
Type
Functional
Frequency
Few
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
Yes
Project
MuseScore crashes when the user clicks OK or Apply in the MuseScore Preferences dialog if there are no scores open at the time.
This crash is 100% reproducible on all platforms and was introduced in PR #5898 for issue #93376: Keep cursor centered during playback in Continuous View.
Workaround: Make sure there is always at least one score open before opening the MuseScore Preferences dialog.
Fix version
3.5.0
Comments
PR #6057.
Fixed in branch 3.x, commit 1665f1b52f
_Fix #305106: Crash when applying preferences with no scores open
Added a missing nullptr check for mscore->currentScoreView() inside PreferenceDialog::apply(), fixing a crash that occurred if the user attempted to apply preferences when there were no scores open.
Also changed ScoreView::panSettings() to return a reference instead of a pointer, eliminating the need for an unnecessary nullptr check._
Fixed in branch 3.x, commit a35dc40a28
_Merge pull request #6057 from Spire42/305106-crash-when-applying-preferences-with-no-scores-open
Fix #305106: Crash when applying preferences with no scores open_
Fixed in branch master, commit 429fae879d
_Merge pull request #6057 from Spire42/305106-crash-when-applying-preferences-with-no-scores-open
Fix #305106: Crash when applying preferences with no scores open_
Automatically closed -- issue fixed for 2 weeks with no activity.