Assertion failure adding image to vertical frame via prioperty menu
Reported version
3.4
Priority
P1 - High
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
Yes
Project
Development builds crash with an assertion failure if you right-click a vertical frame and choose Add / Image. that's because the handler tries to cast the value to an HBox:
https://github.com/musescore/MuseScore/commit/dde36087140d31d7ec428499a…
Previously we got away with this because a static_cast was used, now it's toHBox. It was wrong before but didn't raise an assertion failure. As far as I can see, there's no reason for any of that, just leave it as "e".
Workaround is not use a development build :-)
As far as I can tell there is no harmful effect from this other than development builds. Unlike other assertion failures, this doesn't indicate some unknown condition we aren't going to hands correctly. The cast doesn't do anything.
Fix version
3.5.1
Comments
3.4? Or 3.x-dev?
I don't have a 3.4 development build handy to test with, but it seems the change was implemented back then, so probably it would have affected those as well.
So, not a regression. Also quite irrelevant to real life. Also, PR here: https://github.com/musescore/MuseScore/pull/6327
Well, it is a regression, introduced with 3.4, so vs. 3.3 ;-)
Fixed in branch 3.x, commit 8a19c1532d
_fix #307720: assertion failure adding image to vertical frame
Resolves: https://musescore.org/en/node/307720
we are tryng to cast an element to an HBox that isn't necessarily one.
No reason to do this; it works just fine without the cast._
Fixed in branch 3.x, commit bf8db3a676
_Merge pull request #6327 from MarcSabatella/307720-assert-hbox
fix #307720: assertion failure adding image to vertical frame_
Automatically closed -- issue fixed for 2 weeks with no activity.